chore: update eslint/gulp-eslint to v4 #11036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing it. |
ncoden
approved these changes
Mar 14, 2018
There was a problem hiding this comment.
See https://www.diffchecker.com/SLxCxCEC
So LGTM. There's still a lot of work to do (but I don't think it's a good idea to get into it now), but not more.
|
@ncoden Are you talking about all the warnings and the errors that we need to take care of (Or adjust the lint rules to ignore)? |
|
Yes. In theory we should take care of the warning/errors, but right now (at the end of v6) it is too much work for too small benefits. |
|
On v7 we should use Prettier with the Github integrations :) |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated my global eslint to v4 and started seeing this error from SublimeLinter:
Unexpected top-level property "ecmaVersion"Caused by this line:
https://github.com/zurb/foundation-sites/blob/develop/.eslintrc#L2
That setting is already present and in the correct place on this line:
https://github.com/zurb/foundation-sites/blob/develop/.eslintrc#L20
Figured I might as well update eslint/gulp-eslint for foundation-sites while I was at it.