Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tabs.md typo for data-tabs-target #10603

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Updated tabs.md typo for data-tabs-target #10603

merged 1 commit into from
Sep 10, 2017

Conversation

svenkle
Copy link
Contributor

@svenkle svenkle commented Aug 31, 2017

Removed # from sample code tab target otherwise the example doesn't work with error "Syntax error, unrecognized expression: ##panel2"

Before submitting a pull request, make sure it's targeting the right branch:

  • For documentation fixes, use master.
  • For bug fixes or new features compatible with the next version, use develop.
  • For bug fixes incompatible with develop, use the support branch of the latest compatible version, which will be formatted support/6.x.

If you're fixing a JavaScript issue, it would help to create a new test case under the folder test/visual/ that recreates the issue and show's that it's been fixed. Run npm test to compile the testing folder.

Happy coding! :)

Removed # from sample code tab target otherwise the example doesn't work with error "Syntax error, unrecognized expression: ##panel2"
@kball kball merged commit 5c20827 into foundation:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants