Modified Kitchen Sink Page #10500
Merged
Modified Kitchen Sink Page #10500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added data-closable attribute to callout div
|
Thanks for the PR! This makes the callout closable, but to get it to close, we need to make the close button also have a |
Added data-close to button
|
Thanks, done that now and it works! |
IamManchanda
approved these changes
Aug 5, 2017
IamManchanda
suggested changes
Aug 5, 2017
docs/pages/kitchen-sink.md
Outdated
| <div class="callout"> | ||
| <button class="close-button" aria-label="Close alert" type="button"> | ||
| <div class="callout" data-closable> | ||
| <button class="close-button" aria-label="Close alert" type="button" data-close> | ||
| <span aria-hidden="true">×</span> | ||
| </button> | ||
| <p>This is a static close button example.</p> |
There was a problem hiding this comment.
I think you need to remove the word static ? No ?
Removed static
|
Removed the word static. |
|
Perfect! Merged, thanks @danclayton50! |
This was referenced Jun 16, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added data-closable attribute to closable callout div so it closes properly
That's all!