Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix and improve the description of the default reveal width #10996

Merged
merged 3 commits into from Mar 1, 2018
Merged

docs: fix and improve the description of the default reveal width #10996

merged 3 commits into from Mar 1, 2018

Conversation

DanielRuf
Copy link
Contributor

This provides a better description of the default width of the reveal.

Closes #8707

ncoden
ncoden reviewed Feb 28, 2018
View reviewed changes
docs/pages/reveal.md Outdated
@@ -64,7 +64,7 @@ You can use our handy [close button](close-button.html) styles to do this:

## Sizing

On small screens, a modal is always 100% of the width of the screen. On medium-sized screens and larger, the width changes to 80%.
On small screens, a modal is always 100% of the width of the screen. On medium-sized screens and larger, the width changes to 600px. If you're using the Sass version of Foundation, edit the `$reveal-width` variable to change this. This can be a percentage value, or a pixel value.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to repeat that. You can simply reference the setting with:

(see the $reveal-width setting).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

ncoden
ncoden reviewed Mar 1, 2018
View reviewed changes
docs/pages/reveal.md Outdated
@@ -64,7 +64,7 @@ You can use our handy [close button](close-button.html) styles to do this:

## Sizing

On small screens, a modal is always 100% of the width of the screen. On medium-sized screens and larger, the width changes to 80%.
On small screens, a modal is always 100% of the width of the screen. On medium-sized screens and larger, the width changes to 600px (see the $reveal-width setting).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$reveal-width with "`" 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed =)

@ncoden
Copy link
Contributor

ncoden commented Mar 1, 2018

👍 LGTM, thx

@ncoden ncoden merged commit 9df1045 into foundation:master Mar 1, 2018
@DanielRuf DanielRuf deleted the docs/default-reveal-width-8707 branch March 1, 2018 21:07
@DanielRuf DanielRuf mentioned this pull request Mar 6, 2018
Closed
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@DanielRuf @ncoden
Use pull request foundation#10996 from DanielRuf/docs/default-reveal-…
44274a8 
…width-8707 for v6.5.0

4eb21df docs: fix and improve the description of the default reveal width
d72567d docs: just reference the reveal-width variable
9d5082a add missing backticks

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden left review comments

Assignees
No one assigned
Labels
📖 documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielRuf @ncoden