Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused dependencies #11308

Merged
merged 1 commit into from
May 31, 2018

Conversation

ncoden
Copy link
Contributor

@ncoden ncoden commented May 29, 2018

Description

Remove unused dependencies. These dependencies are not used in CLI, Sass (via eyeglass), JavaScript (via import) or foundation-docs (as globals).

Changes

Remove dependencies:

  • dateformat
  • gaze

Keep dependencies:

  • util-deprecate: it is likely that we will often start and stop using it following the added/removed/outdated deprecations.

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing
    functionality to change)

Checklist (all required):

  • I have read and follow the CONTRIBUTING document.
  • There are no other pull request similar to this one.
  • The pull request title is descriptive.
  • The template is fully and correctly filled.
  • The pull request targets the right branch (develop or support/*).
  • My commits are correctly titled and contain all relevant information.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).
  • All new and existing tests passed.

Remove dependencies:
* `dateformat`
* `gaze`

These dependencies are not used in CLI, JS, Sass or `foundation-docs`.

Keep dependencies:
* `util-deprecate`: it is probable that we will have to add and remove it very often.
@ncoden ncoden requested a review from DanielRuf May 29, 2018 22:04
@ncoden ncoden merged commit 515cb65 into foundation:develop May 31, 2018
Copy link
Contributor

@DanielRuf DanielRuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine to merge.

ncoden added a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
…endencies for v6.5.0

5b84cb5 chore: remove unused dependencies

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants