Drilldown parent fix #10829
Drilldown parent fix #10829
Conversation
There was a problem hiding this comment.
I don't like the way it is implemented (with selectors and a lot of assumptions about the HTML architecture), but the whole framework is like that, this is standard jQuery and I don't see how it could be improved.
I may have this impression because I dev only in Ember for 2 months and we don't deal with the DOM in that framework.
Anyway. LGTM 👍
|
Yeah, I am not really happy with the way I done it, too. But as you said the whole framework works like that. This wasn't the case when we started Foundation 6 I guess, but became more and more this way as more collaborators opened PRs. However, let's hope we can keep it cleaner with F7. |
|
@ncoden I feel your pain. We need to stop using jQuery 😉 while currently working on an angular project I hate looking into old jQuery code more and more. |
|
Same here guys ;) |
…for v6.5.0 e30db54 Fix Drilldown behavior with parent link when using keyboard. 2c4b3f9 Added test for fix for foundation#10803. Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
Implemented suggestion of @dbombine in #10803.
Closes #10803