Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more accurate -zf-zero-breakpoint error message #11103

Merged
merged 1 commit into from
Mar 30, 2018
Merged

more accurate -zf-zero-breakpoint error message #11103

merged 1 commit into from
Mar 30, 2018

Conversation

andycochran
Copy link
Contributor

This PR closes #9268.

For version 7:

  • Consider allowing for custom notes within settings.scss (as ncoden notes).
  • Consider more semantic, mobile-first naming for breakpoints. For example, small applies styles to all devices, so should the first key/value in the breakpoints map be all: 0?

@andycochran andycochran requested a review from ncoden March 28, 2018 16:47
@DanielRuf DanielRuf added the scss label Mar 28, 2018
ncoden
ncoden approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@ncoden ncoden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @andycochran. Better late than never ;)

@ncoden ncoden merged commit 8abdae8 into develop Mar 30, 2018
@ncoden ncoden deleted the andycochran/9268-breakpoint-error-message branch April 7, 2018 17:37
@ncoden ncoden added this to the 6.5.0 milestone Apr 23, 2018
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Jun 16, 2018
@ncoden
Use pull request foundation#11103 from zurb/andycochran/9268-breakpoi…
71525b1 
…nt-error-message for v6.5.0

5d25a09 more accurate -zf-zero-breakpoint error message

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoden ncoden ncoden approved these changes

Assignees
No one assigned
Labels
scss
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.

$-zf-zero-breakpoint error message
3 participants
@andycochran @ncoden @DanielRuf