Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parseRos2idl implementation #37

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Remove parseRos2idl implementation #37

merged 2 commits into from
Jul 26, 2023

Conversation

snosenzo
Copy link
Contributor

Remove parseRos2idl and test files.
Update webpack to not include test files in build.

defunctzombie
defunctzombie approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@defunctzombie defunctzombie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme still references IDL stuff: https://github.com/foxglove/rosmsg#ros-2-definition-usage

@snosenzo snosenzo merged commit b6796e5 into main Jul 26, 2023
1 check passed
@snosenzo snosenzo deleted the remove-ros2idl branch July 26, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@defunctzombie defunctzombie defunctzombie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snosenzo @defunctzombie