Fix payment entry bug: Handle None value in payment_term_outstanding #36455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Payment Entry Bug: Handle None Value in Payment Term Outstanding
Description:
This pull request addresses the bug in the Payment Entry module, which occurs when a Payment Entry is generated from a Purchase Order with payment terms. The issue results in a validation error due to an unexpected None value for the latest.payment_term_outstanding when referencing the Purchase Order on the Payment Entry.
Bug Details:
Module: accounts
Version: Frappe v14.42.0, ERPNext v14.32.1
Root Cause:
The bug occurs because the original code does not handle the case when latest.payment_term_outstanding is None for the Purchase Order reference on the Payment Entry.
Solution:
To fix the issue, I introduced a condition to check whether latest.payment_term_outstanding is None. If it is None, the comparison is bypassed, allowing the Payment Entry to proceed without throwing an error.