Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payment entry bug: Handle None value in payment_term_outstanding #36455

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Fix payment entry bug: Handle None value in payment_term_outstanding #36455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e25441
Fix payment entry bug: Handle None value in payment_term_outstanding
husamhammad Aug 1, 2023
3976e06
fix: Handle None value in payment_term_outstanding V2
husamhammad Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion erpnext/accounts/doctype/payment_entry/payment_entry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,8 @@ def validate_allocated_amount_with_latest_data(self):
d.payment_term
and (
(flt(d.allocated_amount)) > 0
and flt(d.allocated_amount) > flt(latest.payment_term_outstanding)
and latest.payment_term_outstanding
and (flt(d.allocated_amount) > flt(latest.payment_term_outstanding))
)
and self.term_based_allocation_enabled_for_reference(d.reference_doctype, d.reference_name)
):
Expand Down
Loading