fix(packed_item): ensure proper names for ref integrity

[blaggacao]

closes: #37587

[blaggacao]

needs backport to v15; I noticed however, that when not used with mass creation, but from the SO form, namings jump every other name in the series; possibly because despite the name_set flag, names are doubly assigned somewhere.

[codecov]

Codecov Report

Merging #37597 (b3fa516) into develop (3290df5) will decrease coverage by 0.01%.
Report is 5 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #37597      +/-   ##
===========================================
- Coverage    67.32%   67.31%   -0.01%     
===========================================
  Files          757      757              
  Lines        60147    60148       +1     
===========================================
- Hits         40495    40491       -4     
- Misses       19652    19657       +5     

Files	Coverage Δ
erpnext/selling/doctype/sales_order/sales_order.py	79.12% <100.00%> (+0.03%)	⬆️
...pnext/stock/doctype/delivery_trip/delivery_trip.py	62.08% <100.00%> (ø)
erpnext/stock/get_item_details.py	83.06% <100.00%> (ø)

... and 1 file with indirect coverage changes

[s-aga-r]

@blaggacao This is causing an issue #38072.

Moving target.set_new_name() under update_item() should fix both the issues, can you check once?

[blaggacao]

@s-aga-r Unfortunately, this appears to bring back the original issue.

diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py
index c5ad524ef7..de6a0e61c9 100755
--- a/erpnext/selling/doctype/sales_order/sales_order.py
+++ b/erpnext/selling/doctype/sales_order/sales_order.py
@@ -837,11 +837,11 @@ def make_delivery_note(source_name, target_doc=None, skip_item_mapping=False):
 		if target.company_address:
 			target.update(get_fetch_values("Delivery Note", "company_address", target.company_address))
 
-		# set target items names to ensure proper linking with packed_items
-		target.set_new_name()
 		make_packing_list(target)
 
 	def update_item(source, target, source_parent):
+		# set target items names to ensure proper linking with packed_items
+		target.set_new_name()
 		target.base_amount = (flt(source.qty) - flt(source.delivered_qty)) * flt(source.base_rate)
 		target.amount = (flt(source.qty) - flt(source.delivered_qty)) * flt(source.rate)
 		target.qty = flt(source.qty) - flt(source.delivered_qty)

I tried to eliminate this problem class via frappe/frappe#23201

All other invocations of make_delivery_note that depend on a self.is_new() fail. make_packing_list in those workflows is invoked by the validation routine at the proper time (which is skipped during bulk creations with a flag).