Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local reference error in BOM #38850

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

niyazrazak
Copy link
Contributor

image

Replicate Issue
1- Create Bom
2- Select Rate Of Materials Based On "Manual"
3- Save

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Merging #38850 (b50b3fb) into develop (39ef75e) will increase coverage by 0.01%.
Report is 60 commits behind head on develop.
The diff coverage is 83.10%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38850      +/-   ##
===========================================
+ Coverage    60.18%   60.20%   +0.01%     
===========================================
  Files          759      759              
  Lines        69767    69772       +5     
===========================================
+ Hits         41992    42003      +11     
+ Misses       27775    27769       -6     
Files Coverage Δ
erpnext/accounts/deferred_revenue.py 77.50% <100.00%> (ø)
...doctype/invoice_discounting/invoice_discounting.py 70.27% <ø> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 84.15% <100.00%> (ø)
...ounts/doctype/purchase_invoice/purchase_invoice.py 70.12% <ø> (ø)
erpnext/accounts/general_ledger.py 90.67% <ø> (ø)
.../report/accounts_receivable/accounts_receivable.py 89.73% <100.00%> (+0.05%) ⬆️
...t/accounts/report/general_ledger/general_ledger.py 69.64% <100.00%> (ø)
...unts/report/purchase_register/purchase_register.py 86.33% <ø> (ø)
erpnext/accounts/utils.py 73.82% <100.00%> (ø)
erpnext/assets/doctype/asset/asset.py 73.43% <ø> (ø)
... and 22 more

... and 1 file with indirect coverage changes

@niyazrazak niyazrazak changed the title fix: local reference error fix: local reference error in BOM Dec 20, 2023
@rohitwaghchaure rohitwaghchaure merged commit ae35339 into frappe:develop Dec 20, 2023
15 checks passed
mergify bot pushed a commit that referenced this pull request Dec 20, 2023
fix: local reference error
(cherry picked from commit ae35339)
rohitwaghchaure pushed a commit that referenced this pull request Dec 20, 2023
fix: local reference error in BOM (#38850)

fix: local reference error
(cherry picked from commit ae35339)

Co-authored-by: NIYAZ RAZAK <76736615+niyazrazak@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 27, 2023
# [15.8.0](v15.7.0...v15.8.0) (2023-12-27)

### Bug Fixes

* `Reserved Stock` report (backport [#38922](#38922)) ([#38924](#38924)) ([8f643f0](8f643f0))
* allow to set rate manually for service item in BOM (backport [#38880](#38880)) (backport [#38882](#38882)) ([#38885](#38885)) ([74606dc](74606dc))
* do not make serial batch bundle for zero qty (backport [#38949](#38949)) ([#38954](#38954)) ([a41cf62](a41cf62))
* do not reset the basic rate for the material receipt stock entry (backport [#38896](#38896)) ([#38899](#38899)) ([f6eb2b5](f6eb2b5))
* incorrect price list in customer-wise item price report ([e0dbb57](e0dbb57))
* incorrect qty in serial batch bundle against pick list (backport [#38964](#38964)) ([#38966](#38966)) ([5874be0](5874be0))
* local reference error in BOM (backport [#38850](#38850)) ([#38877](#38877)) ([e3be9c1](e3be9c1))
* min order qty optional in production plan (backport [#38956](#38956)) ([#38958](#38958)) ([ab9fce3](ab9fce3))
* not able to import serial batch bundle using csv (backport [#38950](#38950)) ([#38955](#38955)) ([0e48ef7](0e48ef7))
* reposting not fixing valuation rate for sales return using movin… (backport [#38895](#38895)) (backport [#38897](#38897)) ([#38901](#38901)) ([eabb956](eabb956))
* reset the incoming rate on changing of the warehouse (backport [#38925](#38925)) ([#38926](#38926)) ([82960e3](82960e3))
* **test:** expect account currency when party account is specified. ([2d9a0a8](2d9a0a8))
* typeerror on pos order summary to new order screen ([bf98a8f](bf98a8f))
* typerror on tree doctypes - Item Group, Customer Group, Supplier Group and Territory (backport [#38870](#38870)) ([#38871](#38871)) ([d75ac13](d75ac13))
* use party account currency when party account is specified ([32d3d4e](32d3d4e))
* **ux:** make PR and PI Item rate field readonly based on `Maintain Same Rate` (backport [#38942](#38942)) ([#38944](#38944)) ([f704ccb](f704ccb))

### Features

* in_party_currency option for AR/AP reports ([a65bc77](a65bc77))
* provision to add items in Stock Reservation dialog (backport [#38558](#38558)) ([#38920](#38920)) ([8c2c90f](8c2c90f))
* total_asset_cost field (backport [#38879](#38879)) ([#38887](#38887)) ([58f1df5](58f1df5))

### Performance Improvements

* Drop unused/duplicate/sub-optimal indexes (backport [#38884](#38884)) ([#38913](#38913)) ([308c6ff](308c6ff))
* use estimated rows instead of actual rows (backport [#38830](#38830)) ([#38876](#38876)) ([648f275](648f275))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-15-hotfix needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants