perf: Drop unused/duplicate/sub-optimal indexes #38884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
requested review from
rohitwaghchaure,
s-aga-r,
deepeshgarg007 and
ruthra-kumar
as code owners
auto-merge was automatically disabled
December 20, 2023 15:04
Pull request was converted to draft
ankush
force-pushed
the
duplicate_indexes
branch
from
167d90a
to
8462625
Compare
ankush
force-pushed
the
duplicate_indexes
branch
from
8462625
to
9a0c2db
Compare
ankush
added
backport version-15-hotfix
backport version-14-hotfix
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* ci: enable more checks * perf: Drop unused/duplicate indexes (cherry picked from commit 7873338)
mergify bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
* ci: enable more checks * perf: Drop unused/duplicate indexes (cherry picked from commit 7873338) # Conflicts: # erpnext/accounts/doctype/gl_entry/gl_entry.json # erpnext/patches.txt
This was referenced Dec 21, 2023
ankush
added a commit
that referenced
this pull request
Dec 21, 2023
ankush
added a commit
that referenced
this pull request
Dec 21, 2023
…8912) * perf: Drop unused/duplicate/sub-optimal indexes (#38884) * ci: enable more checks * perf: Drop unused/duplicate indexes (cherry picked from commit 7873338) # Conflicts: # erpnext/accounts/doctype/gl_entry/gl_entry.json # erpnext/patches.txt * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
# [14.57.0](v14.56.0...v14.57.0) (2023-12-27) ### Bug Fixes * allow to set rate manually for service item in BOM ([#38880](#38880)) ([c2f692a](c2f692a)) * display all item rate stop messages ([226d0e0](226d0e0)) * do not reset the basic rate for the material receipt stock entry ([#38896](#38896)) ([98bfcc4](98bfcc4)) * first name error on customer creation ([#38927](#38927)) ([28f052d](28f052d)) * german translations for Lost Quotations ([#38435](#38435)) ([81b5e6c](81b5e6c)) * groups for current accounts in German CoAs ([39aa36e](39aa36e)) * incorrect price list in customer-wise item price report ([7577706](7577706)) * min order qty optional in production plan (backport [#38956](#38956)) ([#38957](#38957)) ([f6f2712](f6f2712)) * remove rows with zero consumed qty ([f2f4100](f2f4100)) * reposting not fixing valuation rate for sales return using movin… ([#38895](#38895)) ([3a668bb](3a668bb)) * reset the incoming rate on changing of the warehouse ([#38909](#38909)) ([2770ca1](2770ca1)) * skip jvs against bank accounts ([98198d3](98198d3)) * **test:** expect account currency when party account is specified. ([30cb218](30cb218)) * unset discount amount from coupon discounts ([87e8dd0](87e8dd0)) * use party account currency when party account is specified ([d9e0d55](d9e0d55)) * **ux:** make PR and PI Item rate field readonly based on `Maintain Same Rate` (backport [#38942](#38942)) ([#38943](#38943)) ([1eee203](1eee203)) ### Features * in_party_currency option for AR/AP reports ([3c717db](3c717db)) * total_asset_cost field (backport [#38879](#38879)) ([#38886](#38886)) ([8169c7d](8169c7d)) ### Performance Improvements * Drop unused/duplicate/sub-optimal indexes (backport [#38884](#38884)) ([#38912](#38912)) ([b254a72](b254a72)) * use estimated rows instead of actual rows (backport [#38830](#38830)) ([#38875](#38875)) ([4d1ccd9](4d1ccd9))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
# [15.8.0](v15.7.0...v15.8.0) (2023-12-27) ### Bug Fixes * `Reserved Stock` report (backport [#38922](#38922)) ([#38924](#38924)) ([8f643f0](8f643f0)) * allow to set rate manually for service item in BOM (backport [#38880](#38880)) (backport [#38882](#38882)) ([#38885](#38885)) ([74606dc](74606dc)) * do not make serial batch bundle for zero qty (backport [#38949](#38949)) ([#38954](#38954)) ([a41cf62](a41cf62)) * do not reset the basic rate for the material receipt stock entry (backport [#38896](#38896)) ([#38899](#38899)) ([f6eb2b5](f6eb2b5)) * incorrect price list in customer-wise item price report ([e0dbb57](e0dbb57)) * incorrect qty in serial batch bundle against pick list (backport [#38964](#38964)) ([#38966](#38966)) ([5874be0](5874be0)) * local reference error in BOM (backport [#38850](#38850)) ([#38877](#38877)) ([e3be9c1](e3be9c1)) * min order qty optional in production plan (backport [#38956](#38956)) ([#38958](#38958)) ([ab9fce3](ab9fce3)) * not able to import serial batch bundle using csv (backport [#38950](#38950)) ([#38955](#38955)) ([0e48ef7](0e48ef7)) * reposting not fixing valuation rate for sales return using movin… (backport [#38895](#38895)) (backport [#38897](#38897)) ([#38901](#38901)) ([eabb956](eabb956)) * reset the incoming rate on changing of the warehouse (backport [#38925](#38925)) ([#38926](#38926)) ([82960e3](82960e3)) * **test:** expect account currency when party account is specified. ([2d9a0a8](2d9a0a8)) * typeerror on pos order summary to new order screen ([bf98a8f](bf98a8f)) * typerror on tree doctypes - Item Group, Customer Group, Supplier Group and Territory (backport [#38870](#38870)) ([#38871](#38871)) ([d75ac13](d75ac13)) * use party account currency when party account is specified ([32d3d4e](32d3d4e)) * **ux:** make PR and PI Item rate field readonly based on `Maintain Same Rate` (backport [#38942](#38942)) ([#38944](#38944)) ([f704ccb](f704ccb)) ### Features * in_party_currency option for AR/AP reports ([a65bc77](a65bc77)) * provision to add items in Stock Reservation dialog (backport [#38558](#38558)) ([#38920](#38920)) ([8c2c90f](8c2c90f)) * total_asset_cost field (backport [#38879](#38879)) ([#38887](#38887)) ([58f1df5](58f1df5)) ### Performance Improvements * Drop unused/duplicate/sub-optimal indexes (backport [#38884](#38884)) ([#38913](#38913)) ([308c6ff](308c6ff)) * use estimated rows instead of actual rows (backport [#38830](#38830)) ([#38876](#38876)) ([648f275](648f275))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field appears as first field in multi-col index then it doesn't need to be separately indexed.
Other changes are same as #38827