Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quality inspection creation #43416

Merged
merged 1 commit into from
Sep 28, 2024
Merged

fix: quality inspection creation #43416

merged 1 commit into from
Sep 28, 2024

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  • Create the quality inspection template with "Formula Based Criteria" and formula as "(reading_1 + reading_2) > 3"
  • Create the Purchase Receipt and after that click on Create > Quality Inspection
  • In the popup select the items and click on Create, you will get the below error
Screenshot 2024-09-28 at 8 26 30 PM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 28, 2024
@rohitwaghchaure rohitwaghchaure added backport version-14-hotfix backport to version 14 backport version-15-hotfix and removed needs-tests This PR needs automated unit-tests. labels Sep 28, 2024
@rohitwaghchaure rohitwaghchaure merged commit a594c05 into frappe:develop Sep 28, 2024
14 checks passed
mergify bot pushed a commit that referenced this pull request Sep 28, 2024
@rohitwaghchaure @mergify
fix: quality inspection creation (#43416)
46d3e30 
(cherry picked from commit a594c05)
mergify bot pushed a commit that referenced this pull request Sep 28, 2024
@rohitwaghchaure @mergify
fix: quality inspection creation (#43416)
f2ff47a 
(cherry picked from commit a594c05)

# Conflicts:
#	erpnext/stock/doctype/quality_inspection/quality_inspection.py
This was referenced Sep 28, 2024
Merged
Closed
rohitwaghchaure added a commit that referenced this pull request Sep 29, 2024
@mergify @rohitwaghchaure
fix: quality inspection creation (backport #43416) (#43417)
a1b6628 
fix: quality inspection creation (#43416)

(cherry picked from commit a594c05)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Oct 4, 2024
@frappe-bot
chore(release): Bumped to Version 15.38.0
edfa6e4 
# [15.38.0](v15.37.0...v15.38.0) (2024-10-04)

### Bug Fixes

* 'NoneType' object has no attribute 'has_serial_no' ([21a0157](21a0157))
* add company filter in Warehouse wise Item Balance Age and Value ([4fc6d3e](4fc6d3e))
* adjustmen entry for stock reco ([c551c27](c551c27))
* Cannot read properties of undefined (reading 'price_list_rate') (backport [#43376](#43376)) ([#43377](#43377)) ([47f06dc](47f06dc))
* Data missing in table: None, MandatoryError (backport [#43422](#43422)) ([#43429](#43429)) ([4b3f143](4b3f143))
* **Dunning:** logic for fetching text (backport [#43160](#43160)) ([#43490](#43490)) ([1b28a4e](1b28a4e))
* Fix API endpoint for Frankfurter ([d96cee8](d96cee8))
* Ignore transaction deletion check on ledger entry insertion ([1d6f97a](1d6f97a))
* **Item:** error message on tax rate (backport [#42955](#42955)) ([#42956](#42956)) ([5fc5934](5fc5934))
* last purchase rate for purchase invoice (backport [#43448](#43448)) ([#43452](#43452)) ([ee2c8c8](ee2c8c8))
* negative stock error for batch (backport [#43450](#43450)) ([#43454](#43454)) ([7bf6251](7bf6251))
* patch to update Currency Exchange Settings for `frankfurter.app` (backport [#43481](#43481)) ([#43483](#43483)) ([35a08f8](35a08f8))
* quality inspection creation (backport [#43416](#43416)) ([#43417](#43417)) ([a1b6628](a1b6628))
* **Quotation:** calculate row values for alternative items (backport [#43054](#43054)) ([#43495](#43495)) ([4fa5131](4fa5131))
* removed validation for materials return (backport [#43461](#43461)) ([#43463](#43463)) ([9c0a17e](9c0a17e))
* serial and batch no selector (backport [#43387](#43387)) ([#43390](#43390)) ([74c880c](74c880c))
* set margin fields for purchase documents when updating items ([6516e68](6516e68))
* Stock Ledger Invariant Check report ([2984bad](2984bad))
* Stock UOM not fetched when Stock Entry create from Item Dashboard (backport [#43457](#43457)) ([#43465](#43465)) ([f2a72e5](f2a72e5))
* tests for work order consumption (backport [#41814](#41814)) ([#43430](#43430)) ([86b10ce](86b10ce))
* use serial and batch fields (backport [#43421](#43421)) ([#43423](#43423)) ([d495d93](d495d93))

### Features

* added 'cost of new capitalized asset' column ([27cd51e](27cd51e))
* provide hook point for bulk transaction tasks ([50e47e7](50e47e7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-aga-r s-aga-r Awaiting requested review from s-aga-r s-aga-r is a code owner

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rohitwaghchaure