Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dunning): logic for fetching text (backport #43160) #43490

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2024

Before

(a). If the language parameter is provided, return the text for this language. If this doesn't exist, return None.
(b.) If the language parameter is not provided, return the text marked as Is Default Language. If this doesn't exist, return None.

After

  1. If the language parameter is provided, return the text for this language.
  2. If doc.language exists, return the text for this language.
  3. If a text marked as Is Default Language exists, return this one.
  4. Return an empty dict (-> uniform return type)

How to test

  1. Create a Dunning Type
    • add texts for different languages, enable Is Default Language for one of them
  2. Create overdue Sales Invoices for customers with different languages
  3. Click on "Create" -> "Dunning" in each Sales Invoice
    This is an automatic backport of pull request fix(Dunning): logic for fetching text #43160 done by Mergify.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Oct 2, 2024
@barredterra barredterra merged commit 1b28a4e into version-15-hotfix Oct 3, 2024
12 checks passed
@barredterra barredterra deleted the mergify/bp/version-15-hotfix/pr-43160 branch October 3, 2024 19:28
@barredterra barredterra removed the needs-tests This PR needs automated unit-tests. label Oct 3, 2024
frappe-pr-bot pushed a commit that referenced this pull request Oct 4, 2024
# [15.38.0](v15.37.0...v15.38.0) (2024-10-04)

### Bug Fixes

* 'NoneType' object has no attribute 'has_serial_no' ([21a0157](21a0157))
* add company filter in Warehouse wise Item Balance Age and Value ([4fc6d3e](4fc6d3e))
* adjustmen entry for stock reco ([c551c27](c551c27))
* Cannot read properties of undefined (reading 'price_list_rate') (backport [#43376](#43376)) ([#43377](#43377)) ([47f06dc](47f06dc))
* Data missing in table: None, MandatoryError (backport [#43422](#43422)) ([#43429](#43429)) ([4b3f143](4b3f143))
* **Dunning:** logic for fetching text (backport [#43160](#43160)) ([#43490](#43490)) ([1b28a4e](1b28a4e))
* Fix API endpoint for Frankfurter ([d96cee8](d96cee8))
* Ignore transaction deletion check on ledger entry insertion ([1d6f97a](1d6f97a))
* **Item:** error message on tax rate (backport [#42955](#42955)) ([#42956](#42956)) ([5fc5934](5fc5934))
* last purchase rate for purchase invoice (backport [#43448](#43448)) ([#43452](#43452)) ([ee2c8c8](ee2c8c8))
* negative stock error for batch (backport [#43450](#43450)) ([#43454](#43454)) ([7bf6251](7bf6251))
* patch to update Currency Exchange Settings for `frankfurter.app` (backport [#43481](#43481)) ([#43483](#43483)) ([35a08f8](35a08f8))
* quality inspection creation (backport [#43416](#43416)) ([#43417](#43417)) ([a1b6628](a1b6628))
* **Quotation:** calculate row values for alternative items (backport [#43054](#43054)) ([#43495](#43495)) ([4fa5131](4fa5131))
* removed validation for materials return (backport [#43461](#43461)) ([#43463](#43463)) ([9c0a17e](9c0a17e))
* serial and batch no selector (backport [#43387](#43387)) ([#43390](#43390)) ([74c880c](74c880c))
* set margin fields for purchase documents when updating items ([6516e68](6516e68))
* Stock Ledger Invariant Check report ([2984bad](2984bad))
* Stock UOM not fetched when Stock Entry create from Item Dashboard (backport [#43457](#43457)) ([#43465](#43465)) ([f2a72e5](f2a72e5))
* tests for work order consumption (backport [#41814](#41814)) ([#43430](#43430)) ([86b10ce](86b10ce))
* use serial and batch fields (backport [#43421](#43421)) ([#43423](#43423)) ([d495d93](d495d93))

### Features

* added 'cost of new capitalized asset' column ([27cd51e](27cd51e))
* provide hook point for bulk transaction tasks ([50e47e7](50e47e7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant