Distinguish between grid meters and other meters #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:tests
It was possible to have a grid meter identified as a pv/ev/battery/chp
meter for specific component graph configurations.
But grid meters might also be measuring site consumption, so the above
use was incorrect. This is fixed by adding a `is_grid_meter` check to
the component graph `is_{pv/ev/battery/chp}_meter` methods.
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
Marenz
previously approved these changes
Aug 26, 2024
shsms
force-pushed
the
grid-meter-check
branch
from
126cb58
to
c08f7c9
Compare
Marenz
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The component graph methods for identifying meters as {pv/ev/battery/chp} meters were sometimes incorrectly identifying grid meters as one of {pv/ev/battery/chp} meters.
This PR fixes that issue.