Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distinguish between grid meters and other meters #1052

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Distinguish between grid meters and other meters #1052

merged 3 commits into from
Aug 26, 2024

Commits on Aug 26, 2024

  1. Distinguish between grid meters and {pv/ev/battery/chp} meters 

    It was possible to have a grid meter identified as a pv/ev/battery/chp
meter for specific component graph configurations.

But grid meters might also be measuring site consumption, so the above
use was incorrect.  This is fixed by adding a `is_grid_meter` check to
the component graph `is_{pv/ev/battery/chp}_meter` methods.

Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
    @shsms
    shsms committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    a829a8d View commit details
    Browse the repository at this point in the history

  2. Test the ComponentGraph.is_{pv/ev/battery/chp}_{meter/chain} methods 

    Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
    @shsms
    shsms committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    964a336 View commit details
    Browse the repository at this point in the history

  3. Update release notes 

    Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>
    @shsms
    shsms committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    c08f7c9 View commit details
    Browse the repository at this point in the history