Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reqwest default tls feature #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

flosse
Copy link
Contributor

@flosse flosse commented Aug 29, 2022

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Cargo.toml Show resolved Hide resolved
@lnicola
Copy link
Member

lnicola commented Feb 13, 2023

r? @urschrei

@urschrei
Copy link
Member

This will need a rebase when #57 merges, right?

@michaelkirk
Copy link
Member

The chrono work was just merged in #60 so this will at least need a rebase.

But also... what is this PR doing? Is it disabling TLS? Why would we want that?

@michaelkirk
Copy link
Member

Oh, I think I understand.

We want people to be able to choose their tls backend, which are already exposed by geocoding features:

[features]
default = ["reqwest/default"] # this builds default-tls
rustls-tls = ["reqwest/rustls-tls"] # this builds rust-tls

But we were erroneously (redundantly) declaring that reqwest always builds default-tls, so there was no way to use only rust-tls without this PR. Is that right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants