Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove chrono #60

Merged
merged 3 commits into from
Oct 5, 2023
Merged

remove chrono #60

merged 3 commits into from
Oct 5, 2023

Conversation

michaelkirk
Copy link
Member

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Supersedes #57 (rebased and conflicts addressed)

@michaelkirk michaelkirk requested a review from lnicola July 11, 2023 22:53
@michaelkirk michaelkirk mentioned this pull request Jul 11, 2023
Closed
nyurik
nyurik approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. One thing I think we should do is sort the dependencies section in cargo.toml, but this is not a blocker

@michaelkirk michaelkirk merged commit 1343f2b into master Oct 5, 2023
4 checks passed
@michaelkirk michaelkirk mentioned this pull request Oct 5, 2023
Open
2 tasks
@nyurik nyurik deleted the mkirk/remove-chrono branch October 5, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik approved these changes

@lnicola lnicola Awaiting requested review from lnicola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelkirk @nyurik @flosse