Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

share_post: Reverting removal of summary for the plugin to be usable #556

Merged
merged 1 commit into from
Sep 14, 2015

Conversation

davidmarquis
Copy link
Contributor

Otherwise code would not compile (summary variable is still used)

Closes #549

@kernc
Copy link
Contributor

kernc commented Sep 13, 2015

Nitpicking, but revert commits are best made with git revert (it's the message that matters).
You could further append a string like

Closes #549

to the commit message to also auto-close the associated open issue once the change is merged.

(You can change the message of this commit with git commit --amend and then git push --force.)

@davidmarquis
Copy link
Contributor Author

Updated commit and pull request!

@justinmayer
Copy link
Member

Thanks, @davidmarquis and @kernc, for your contributions here. (^_^)

justinmayer added a commit that referenced this pull request Sep 14, 2015
share_post: Reverting removal of summary for the plugin to be usable
@justinmayer justinmayer merged commit 14251f0 into getpelican:master Sep 14, 2015
@avaris
Copy link
Member

avaris commented Sep 15, 2015

Umm, won't this bring back the issues related to getpelican/pelican#1616? To be precise, accessing content.summary in content_object_init signal.

cc: @kernc @davidmarquis

@kernc
Copy link
Contributor

kernc commented Sep 15, 2015

Thanks! Indeed it should. 😃 It was even part of the same PR, just didn't contain the signal switch as I probably considered it, without any affected attributes, unnecessary.

Making the plugin fire on all_generators_finalized should fix it.

@davidmarquis, would you like to, since you messed it up? 😛

sanjayankur31 added a commit to UHBiocomputation/pelican-plugins that referenced this pull request Oct 27, 2015
I'm not really sure if this is the right way of going about it, but it
certainly works. :)
sanjayankur31 added a commit to UHBiocomputation/pelican-plugins that referenced this pull request Oct 27, 2015
I'm not sure if this is the right way of going about it, but it
certainly works and fixes getpelican#556. :)
kernc added a commit to kernc/pelican-plugins that referenced this pull request Nov 8, 2015
kernc added a commit to kernc/pelican-plugins that referenced this pull request Nov 8, 2015
kernc added a commit to kernc/pelican-plugins that referenced this pull request Nov 8, 2015
justinmayer pushed a commit to pelican-plugins/share-post that referenced this pull request Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants