-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
share_post: Reverting removal of summary for the plugin to be usable #556
Conversation
Nitpicking, but revert commits are best made with
to the commit message to also auto-close the associated open issue once the change is merged. (You can change the message of this commit with |
This reverts commit fcdab23. Closes getpelican#549
2da9862
to
a71eb53
Compare
Updated commit and pull request! |
Thanks, @davidmarquis and @kernc, for your contributions here. (^_^) |
share_post: Reverting removal of summary for the plugin to be usable
Umm, won't this bring back the issues related to getpelican/pelican#1616? To be precise, accessing cc: @kernc @davidmarquis |
Thanks! Indeed it should. 😃 It was even part of the same PR, just didn't contain the signal switch as I probably considered it, without any affected attributes, unnecessary. Making the plugin fire on @davidmarquis, would you like to, since you messed it up? 😛 |
I'm not really sure if this is the right way of going about it, but it certainly works. :)
I'm not sure if this is the right way of going about it, but it certainly works and fixes getpelican#556. :)
Fixes #577. Closes #598. Ref: * getpelican/pelican-plugins#577 * getpelican/pelican-plugins#556 (comment)
Otherwise code would not compile (
summary
variable is still used)Closes #549