Add signal: all_generators_finalized (see getpelican/pelican-plugins#314) #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some plugins have used `content_object_init` signal and read `summary`
or `content` properties of the content object. This resulted in
internal (`{filename}`) links being unresolved. When used, this signal
should hopefully mitigate that.
See also:
* getpelican/pelican-plugins#314
* getpelican/pelican-plugins#410
kernc
added a commit
to kernc/pelican-plugins
that referenced
this pull request
Feb 7, 2015
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue getpelican#314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616
kernc
added a commit
to kernc/pelican-plugins
that referenced
this pull request
Feb 7, 2015
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue getpelican#314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes getpelican#314.
|
Excellent work, @kernc. Many thanks for this addition! |
justinmayer
added a commit
that referenced
this pull request
Feb 11, 2015
Add signal: all_generators_finalized (see getpelican/pelican-plugins#314)
kernc
added a commit
to kernc/pelican-plugins
that referenced
this pull request
Jul 4, 2015
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue getpelican#314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes getpelican#314.
kernc
added a commit
to kernc/pelican-plugins
that referenced
this pull request
Jul 12, 2015
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue getpelican#314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes getpelican#314.
MinchinWeb
pushed a commit
to MinchinWeb/minchin.pelican.plugins.summary
that referenced
this pull request
Jan 30, 2017
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
viktorbengtsson
added a commit
to viktorbengtsson/pelican-readtime
that referenced
this pull request
Mar 20, 2017
…name} Changed signal from content_object_init to all_generators_finalized (see getpelican/pelican#1616) Changed read_time to operate on content instances in generators Disabled READTIME_CONTENT_SUPPORT setting.
mirekdlugosz
pushed a commit
to mirekdlugosz/pelican-plugins-summary
that referenced
this pull request
Oct 25, 2020
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
cav71
pushed a commit
to cav71/summary
that referenced
this pull request
Mar 8, 2021
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
justinmayer
pushed a commit
to pelican-plugins/read-more
that referenced
this pull request
Mar 11, 2021
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
schtobia
pushed a commit
to schtobia/representative_image
that referenced
this pull request
Aug 7, 2023
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
justinmayer
pushed a commit
to pelican-plugins/featured-image
that referenced
this pull request
Aug 8, 2023
clean_summary, read_more_link, representative_image, summary plugins now use all_generators_finalized signal so as to avoid issue #314. They fallback to current behavior is said signal is not yet available. See also: getpelican/pelican#1616 Closes #314.
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some plugins have used
content_object_initsignal and readsummaryorcontentproperties of the content object. This resulted in internal ({filename}) links being unresolved. When used, this new signalall_generators_finalizedshould hopefully mitigate that.See also: