Change: disable version counter for queries: #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the move to SQLAlchemy, version is managed automatically. When running a query, the worker updates the query row and increments the version. This results in the user's inability to save the query after that. From reviewing SQLA's documentation, it looks like we will have to manage the version value ourselves. For now, I'm just disabling the version auto increment. In a follow up update we need to actually implement the manual increment where we think it's needed.
2 tasks
dairyo
pushed a commit
to KiiCorp/redash
that referenced
this pull request
Mar 1, 2019
Change: disable version counter for queries:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the move to SQLAlchemy, version is managed automatically. When running a query, the worker updates the query row and increments the version. This results in the user's inability to save the query after that.
From reviewing SQLA's documentation, it looks like we will have to manage the version value ourselves. For now, I'm just disabling the version auto increment. In a follow up update we need to actually implement the manual increment where we think it's needed.