Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: disable version counter for queries: #1549

Merged
merged 4 commits into from
Jan 26, 2017
Merged

Change: disable version counter for queries: #1549

merged 4 commits into from
Jan 26, 2017

Commits on Jan 26, 2017

  1. Remove unused code

    @arikfr
    arikfr committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    7ffa8f8 View commit details
    Browse the repository at this point in the history

  2. Disable version counter for queries: 

    Since the move to SQLAlchemy, version is managed automatically.
When running a query, the worker updates the query row and increments
the version. This results in the user's inability to save the query
after that.

From reviewing SQLA's documentation, it looks like we will have to
manage the version value ourselves. For now, I'm just disabling the
version auto increment. In a follow up update we need to actually
implement the manual increment where we think it's needed.
    @arikfr
    arikfr committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    cd51076 View commit details
    Browse the repository at this point in the history

  3. Set default value for query version

    @arikfr
    arikfr committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    ae2927d View commit details
    Browse the repository at this point in the history

  4. Disable query version check in test (#1550)

    @arikfr
    arikfr committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    6cf1c1c View commit details
    Browse the repository at this point in the history