Add Backup/restore scripts #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hubertdeng123
commented
Mar 14, 2023
•
hubertdeng123
commented
- adds backup and restore scripts
- added error reporting to both of the scripts
- consolidate utility scripts to a helper script file
hubertdeng123
force-pushed
the
hubertdeng123/add-reset-backup-scripts
branch
from
41d2c6c
to
15d4ae0
Compare
BYK
reviewed
Mar 15, 2023
utilities.sh
Outdated
| } | ||
|
|
||
| function backup() { | ||
| docker-compose run -v $(pwd)/sentry:/sentry-data/backup --rm -T -e SENTRY_LOG_LEVEL=CRITICAL web export /sentry-data/backup/backup.json |
There was a problem hiding this comment.
I'd ensure the permissions here with chmod +w or something.
hubertdeng123
force-pushed
the
hubertdeng123/add-reset-backup-scripts
branch
from
15d4ae0
to
d9dae7d
Compare
hubertdeng123
commented
Mar 17, 2023
| @@ -1,12 +1,12 @@ | |||
| #!/usr/bin/env bash | |||
| set -euo pipefail | |||
| set -eEuo pipefail | |||
There was a problem hiding this comment.
Is there a reason why we're not including the -E flag generally? If an error is thrown in a function, our cleanup function actually doesn't catch it properly and treats it as the EXIT trap code instead of ERR. Found that out in this PR
https://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html
There was a problem hiding this comment.
Is there a reason why we're not including the
-Eflag generally?
No good one that I know of. :)
chadwhitacre
requested changes
Mar 17, 2023
There was a problem hiding this comment.
Brainstormed #2035, buuuuuuuuut ...
- move everything from
utilitiesintoscriptsfor now - rename
clean.shback toreset.sh - DRY up the
{backup,reset,restore}.shscripts amap (while keeping separate .sh files)
hubertdeng123
force-pushed
the
hubertdeng123/add-reset-backup-scripts
branch
from
0b0eb3f
to
56bd583
Compare
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.