Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make self-hosted backup/restore work excellently #104

Closed
9 tasks done
Tracked by #64
hubertdeng123 opened this issue Feb 3, 2023 · 9 comments
Closed
9 tasks done
Tracked by #64

Make self-hosted backup/restore work excellently #104

hubertdeng123 opened this issue Feb 3, 2023 · 9 comments
Assignees

Comments

@hubertdeng123
Copy link
Member

hubertdeng123 commented Feb 3, 2023

Currently, the backup/restore workflow experience is not great, and users are unhappy about it. Backup/restore is best practices for upgrading self-hosted versions, and is particularly important when the postgres version or our DB models change. It is also used for migrating from self-hosted to SaaS. The issue about backup/restore being broken is the most commented open source issue in the Sentry repo, and has as many unique commenters as the most commented issues in the self-hosted repo.

Screen Shot 2023-01-17 at 9 41 24 AM

Backup/restore is also important for users that want to migrate to SaaS. To make this experience better, we should

Self-hosted issues:

  1. Fix backup/restore flow sentry#36868
  2. sentry_environment is not backed up and breaks alerts logic self-hosted#1965
  3. DB duplicate key violation errors during backup/restore self-hosted#1972

SaaS related concerns:

  1. Make sure the documented workflow for migrating works
  2. See if we can make the self-hosted to SaaS migrations we handle easier for ourselves

Future possibilities enabled from this ticket:

  1. Migrate data from a single org deployment of Sentry to a multi-org one self-hosted#1403
  2. One-click SaaS migration
  3. Migration from one region to another (e.g. US -> EU)

Task list:

  1. Try following SaaS migration docs and self-hosted backup/restore docs and see what breaks. Experiment with changing settings to work different parts of what is backed up.
  2. Investigate and fix Deserialization errors during backup/restore
  3. Investigate and fix db integrity errors during backup/restore
  4. Write Sentry tests to cover what is currently broken with documented workflows.
  5. Fix backup restore to pass new Sentry tests
  6. Remove headers from backup/restore  self-hosted#1995
  7. Add integration tests for backup/restore workflow self-hosted#1918
  8. Dogfood backup/restore self-hosted#1986
  9. vanguard post

┆Issue is synchronized with this Jira Epic by Unito

@hubertdeng123
Copy link
Member Author

So far, there are three main issues with backup/restore that I am aware of.

  1. Backup file includes garbage headers
  2. Deserialization errors during import
  3. Unique key violation during import

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Feb 13, 2023

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Feb 21, 2023

Weekly Update 2/21

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Feb 28, 2023

Weekly Update 2/27

  • Remove headers in backup file
  • Put up draft PR for integration test for backup/restore in self-hosted

Ended up not wrapping up PR for integration tests due to pivoting between other tasks

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Mar 7, 2023

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Mar 13, 2023

@hubertdeng123
Copy link
Member Author

hubertdeng123 commented Mar 20, 2023

Weekly Update 3/20

  • [ ]Tasks for this Epic are now finished. Will do one final team review before closing
  • vanguard post

@hubertdeng123
Copy link
Member Author

shipped vanguard post! closing this now :)

@chadwhitacre
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants