Skip to content

Commit

Permalink
Revert "feat: Track usage of the enableCaptureFailedRequests option (#…
Browse files Browse the repository at this point in the history
…2368)"

This reverts commit a6899a2.
  • Loading branch information
philipphofmann authored Nov 8, 2022
1 parent 01057a9 commit 9e4613c
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 25 deletions.
4 changes: 0 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@

## Unreleased

### Features

- Report usage of enableCaptureFailedRequests (#2368)

### Fixes

- Fix issue with invalid profiles uploading (#2358 and #2359)
Expand Down
2 changes: 1 addition & 1 deletion Sources/Sentry/Public/SentryOptions.h
Original file line number Diff line number Diff line change
Expand Up @@ -416,7 +416,7 @@ NS_SWIFT_NAME(Options)

/**
* When enabled, the SDK captures HTTP Client errors. Default value is NO.
* This feature requires enableSwizzling enabled as well, default value is YES.
* This feature requires enableSwizzling enabled as well, Default value is YES.
*/
@property (nonatomic, assign) BOOL enableCaptureFailedRequests;

Expand Down
4 changes: 0 additions & 4 deletions Sources/Sentry/SentryClient.m
Original file line number Diff line number Diff line change
Expand Up @@ -654,10 +654,6 @@ - (void)setSdk:(SentryEvent *)event
if (self.options.stitchAsyncCode) {
[integrations addObject:@"StitchAsyncCode"];
}

if (self.options.enableCaptureFailedRequests) {
[integrations addObject:@"CaptureFailedRequests"];
}
}

event.sdk = @{
Expand Down
16 changes: 0 additions & 16 deletions Tests/SentryTests/SentryClientTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1047,22 +1047,6 @@ class SentryClientTest: XCTestCase {
)
}
}

func testTrackEnableCaptureFailedRequests() {
SentrySDK.start(options: Options())

let eventId = fixture.getSut(configureOptions: { options in
options.enableCaptureFailedRequests = true
}).capture(message: fixture.messageAsString)

eventId.assertIsNotEmpty()
assertLastSentEvent { actual in
assertArrayEquals(
expected: ["AutoBreadcrumbTracking", "AutoSessionTracking", "Crash", "NetworkTracking", "CaptureFailedRequests"],
actual: actual.sdk?["integrations"] as? [String]
)
}
}

func testSetSDKIntegrations_NoIntegrations() {
let expected: [String] = []
Expand Down

0 comments on commit 9e4613c

Please sign in to comment.