Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Track usage of the enableCaptureFailedRequests option #2368

Merged

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Nov 7, 2022

📜 Description

We can now report usage of the enableCaptureFailedRequests option, as an integration.

(Very similar to #2281.)

💡 Motivation and Context

Closes #2354

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7b55845

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kevinrenskers.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinrenskers kevinrenskers merged commit a6899a2 into master Nov 8, 2022
@kevinrenskers kevinrenskers deleted the feature/2354-track-enableCaptureFailedRequests branch November 8, 2022 10:04
kevinrenskers added a commit that referenced this pull request Nov 8, 2022
* master:
  chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349)
  feat: Track usage of the enableCaptureFailedRequests option (#2368)
kevinrenskers added a commit that referenced this pull request Nov 9, 2022
* master:
  chore: Add match_local to Fastfile
  Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371)
kevinrenskers added a commit that referenced this pull request Nov 9, 2022
* master:
  chore: Add match_local to Fastfile
  Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371)
  chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349)
  feat: Track usage of the enableCaptureFailedRequests option (#2368)
  Update SentryNetworkTrackerIntegrationTests.swift (#2366)
  Fix typos in NetworkTrackerIntegrationTests (#2367)
  build(deps): bump github/codeql-action from 2.1.30 to 2.1.31 (#2364)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Track usage of HTTP Client errors
2 participants