chore: Remove PrivateSentrySDKOnly.h from umbrella header #2349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Wouldn't it make sense to do everything in one PR instead? Now, this PR doesn't add any value. |
brustolin
changed the title
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bdfccaa | 1202.83 ms | 1228.96 ms | 26.13 ms |
| 0fdf0b2 | 1249.20 ms | 1254.08 ms | 4.88 ms |
| d47c2c0 | 1230.55 ms | 1250.22 ms | 19.67 ms |
| 64225be | 1213.96 ms | 1227.62 ms | 13.66 ms |
| b15627c | 1228.88 ms | 1269.70 ms | 40.82 ms |
| f6eee7c | 1227.39 ms | 1240.76 ms | 13.37 ms |
| 5ecf9f6 | 1230.76 ms | 1232.86 ms | 2.10 ms |
| 0fdf0b2 | 1266.27 ms | 1277.90 ms | 11.63 ms |
| 6dc0bd1 | 1220.49 ms | 1237.44 ms | 16.95 ms |
| 7138b7d | 1243.40 ms | 1252.08 ms | 8.68 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| bdfccaa | 20.50 KiB | 361.80 KiB | 341.29 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| d47c2c0 | 20.50 KiB | 342.31 KiB | 321.80 KiB |
| 64225be | 20.50 KiB | 339.02 KiB | 318.52 KiB |
| b15627c | 20.50 KiB | 337.76 KiB | 317.25 KiB |
| f6eee7c | 20.50 KiB | 361.89 KiB | 341.39 KiB |
| 5ecf9f6 | 20.51 KiB | 332.66 KiB | 312.15 KiB |
| 0fdf0b2 | 20.51 KiB | 332.90 KiB | 312.39 KiB |
| 6dc0bd1 | 20.51 KiB | 333.58 KiB | 313.07 KiB |
| 7138b7d | 20.51 KiB | 331.79 KiB | 311.28 KiB |
Previous results on branch: feat/before-removing-PrivateSDK
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c0a8d2 | 1221.55 ms | 1245.34 ms | 23.79 ms |
| 212d5eb | 1212.42 ms | 1235.22 ms | 22.80 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3c0a8d2 | 20.50 KiB | 365.18 KiB | 344.68 KiB |
| 212d5eb | 20.50 KiB | 365.18 KiB | 344.68 KiB |
brustolin
changed the title
|
@brustolin, what's stopping us from merging this PR? |
kevinrenskers
added a commit
that referenced
this pull request
Nov 9, 2022
* master: chore: Add match_local to Fastfile Revert "feat: Track usage of the enableCaptureFailedRequests option (#2368)" (#2371) chore: Remove PrivateSentrySDKOnly.h from umbrella header (#2349) feat: Track usage of the enableCaptureFailedRequests option (#2368) Update SentryNetworkTrackerIntegrationTests.swift (#2366) Fix typos in NetworkTrackerIntegrationTests (#2367) build(deps): bump github/codeql-action from 2.1.30 to 2.1.31 (#2364)
|
It seems that after this change was made, I get build errors in my Tuist-generated project. I'm no expert on this, but why is it that a file named "PrivateSentrySDKOnly.h" was added to |
|
Yes, kind of a mistake, @denizdogan. Can you clean your build and retry, please? |
|
@philipphofmann Sure thing, still breaks unfortunately: $ rm -rf ~/Library/Developer/Xcode/DerivedData && tuist clean && tuist fetch && tuist generate -n && tuist build
...
[Sentry] Compiling SentryTracer.m
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:87:28: redefinition of 'SentryLogLevel'
typedef NS_ENUM(NSInteger, SentryLogLevel) {
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:88:5: redefinition of enumerator 'kSentryLogLevelNone'
kSentryLogLevelNone = 1,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:89:5: redefinition of enumerator 'kSentryLogLevelError'
kSentryLogLevelError,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:90:5: redefinition of enumerator 'kSentryLogLevelDebug'
kSentryLogLevelDebug,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:91:5: redefinition of enumerator 'kSentryLogLevelVerbose'
kSentryLogLevelVerbose
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:97:29: redefinition of 'SentryLevel'
typedef NS_ENUM(NSUInteger, SentryLevel) {
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:99:5: redefinition of enumerator 'kSentryLevelNone'
kSentryLevelNone = 0,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:101:5: redefinition of enumerator 'kSentryLevelDebug'
kSentryLevelDebug = 1,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:102:5: redefinition of enumerator 'kSentryLevelInfo'
kSentryLevelInfo = 2,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:103:5: redefinition of enumerator 'kSentryLevelWarning'
kSentryLevelWarning = 3,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:104:5: redefinition of enumerator 'kSentryLevelError'
kSentryLevelError = 4,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:105:5: redefinition of enumerator 'kSentryLevelFatal'
kSentryLevelFatal = 5
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:111:28: redefinition of 'SentryPermissionStatus'
typedef NS_ENUM(NSInteger, SentryPermissionStatus) {
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:112:5: redefinition of enumerator 'kSentryPermissionStatusUnknown'
kSentryPermissionStatusUnknown = 0,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:113:5: redefinition of enumerator 'kSentryPermissionStatusGranted'
kSentryPermissionStatusGranted,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:114:5: redefinition of enumerator 'kSentryPermissionStatusPartial'
kSentryPermissionStatusPartial,
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:115:5: redefinition of enumerator 'kSentryPermissionStatusDenied'
kSentryPermissionStatusDenied
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:122:67: redefinition of 'SentryLevelNames'
"Use nameForSentryLevel() instead.") NSString *_Nonnull const SentryLevelNames[]
^
❌ /Users/deniz/Library/Developer/Xcode/DerivedData/<proj>/Build/Products/Debug-iphonesimulator/Sentry.framework/Headers/SentryDefines.h:132:25: redefinition of 'defaultMaxBreadcrumbs'
static NSUInteger const defaultMaxBreadcrumbs = 100;
^
❌ fatal error: too many errors emitted, stopping now [-ferror-limit=]
[Sentry] Compiling SentryTraceHeader.m
[Sentry] Compiling SentryTraceContext.m
[Sentry] Compiling SentryTime.mm
[Sentry] Compiling SentryThreadWrapper.m
[Sentry] Compiling SentryThreadMetadataCache.cpp
[Sentry] Compiling SentryThreadInspector.m
[Sentry] Compiling SentryThreadHandle.cpp
[Sentry] Compiling SentryThread.m
[Sentry] Compiling SentrySystemEventBreadcrumbs.m
[Sentry] Compiling SentrySysctl.m
[Sentry] Compiling SentrySwizzleWrapper.m
[Sentry] Compiling SentrySwizzle.m
[Sentry] Compiling SentrySubClassFinder.m
[Sentry] Compiling SentryStacktraceBuilder.m
The 'xcodebuild' command exited with error code 65
Consider creating an issue using the following link: https://github.com/tuist/tuist/issues/new/choose
|
|
@brustolin, do you know what could lead to the error above ⬆️? |
|
I'm observing the same issue as described by @denizdogan with a tuist-generated project. |
|
Hi @philipphofmann and thanks for your answer. |
|
@kyrillc, can you maybe give us a small sample project to reproduce the issue, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove PrivateSentrySDKOnly.h from umbrella headers to prevent users from use it by mistake.
#skip-changelog