Skip to content

Commit

Permalink
Merged ISpanContext into ITraceContext (#2668)
Browse files Browse the repository at this point in the history
  • Loading branch information
jamescrosswell authored Sep 26, 2023
1 parent 8706936 commit 300f248
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 13 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ without native/platform specific bindings and SDKs. See [this ticket for more de

API Changes:

- ISpanContext was removed. Use ITraceContext instead. ([#2668](https://github.com/getsentry/sentry-dotnet/pull/2668))
- Removed IHasTransactionNameSource. Use ITransactionContext instead. ([#2654](https://github.com/getsentry/sentry-dotnet/pull/2654))
- Adding `Distribution` to `IEventLike` ([#2660](https://github.com/getsentry/sentry-dotnet/pull/2660))

Expand Down
10 changes: 0 additions & 10 deletions src/Sentry/ISpanContext.cs

This file was deleted.

4 changes: 3 additions & 1 deletion src/Sentry/ISpanData.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Immutable data belonging to a span.
/// </summary>
public interface ISpanData : ISpanContext, IHasTags, IHasExtra
public interface ISpanData : ITraceContext, IHasTags, IHasExtra
{
/// <summary>
/// Start timestamp.
Expand Down
4 changes: 3 additions & 1 deletion src/Sentry/ITransactionContext.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Transaction metadata.
/// </summary>
public interface ITransactionContext : ISpanContext
public interface ITransactionContext : ITraceContext
{
/// <summary>
/// Transaction name.
Expand Down
4 changes: 3 additions & 1 deletion src/Sentry/SpanContext.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using Sentry.Protocol;

namespace Sentry;

/// <summary>
/// Span metadata used for sampling.
/// </summary>
public class SpanContext : ISpanContext
public class SpanContext : ITraceContext
{
/// <inheritdoc />
public SpanId SpanId { get; }
Expand Down

0 comments on commit 300f248

Please sign in to comment.