-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged ISpanContext into ITraceContext #2668
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Merged ISpanContext into ITraceContext ([#2668](https://github.com/getsentry/sentry-dotnet/pull/2668)) If none of the above apply, you can opt out of this check by adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note on release notes/migration guide.
CHANGELOG.md
Outdated
@@ -14,6 +14,10 @@ without native/platform specific bindings and SDKs. See [this ticket for more de | |||
|
|||
- Drop .NET 6 Mobile in favor of .NET 7 ([#2624](https://github.com/getsentry/sentry-dotnet/pull/2604)) | |||
|
|||
API Changes: | |||
|
|||
- Removed ISpanContext ([#2668](https://github.com/getsentry/sentry-dotnet/pull/2668)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this affect the end user in any way? Doesn't seem so, but worth being clear here.
At the end of the day we'll need a migration guide so users know what steps users need to take in order to upgrade the SDK. So when we say a type was removed, they might expect: "Ok what do I need to do to replace it?". In this case it's possibly just "This type had no documented use and if somehow you used it, it can be replaced with ITraceContext
" or something like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll try to paraphrase that in the changelog for now... and put a bit more detail in the PR notes that we can use when preparing the migration guide proper.
This interface contained no properties or methods... and only impleneted
ITraceContext
so is entirelyreplacable byITraceContext
.Migration Notes
Methods and properties now available on
ITraceContext
(although likely soon to be merged intoISpanData
- so we'll probably tell users to look for the methods and properties onISpanData
instead).