Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP request breadcrumb #1113

Merged
merged 9 commits into from
Jul 10, 2021
Merged

Add HTTP request breadcrumb #1113

merged 9 commits into from
Jul 10, 2021

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman added the Feature New feature or request label Jul 9, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2021

Codecov Report

Merging #1113 (6ed7283) into main (2ee1a05) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1113      +/-   ##
==========================================
+ Coverage   80.81%   80.84%   +0.02%     
==========================================
  Files         195      195              
  Lines        6391     6400       +9     
  Branches     1412     1413       +1     
==========================================
+ Hits         5165     5174       +9     
  Misses        764      764              
  Partials      462      462              
Impacted Files Coverage Δ
src/Sentry/SentryHttpMessageHandler.cs 84.21% <90.00%> (+4.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee1a05...6ed7283. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues and no tests for this code. I left a comment

src/Sentry/SentryHttpMessageHandler.cs Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia merged commit 4fe2084 into main Jul 10, 2021
@bruno-garcia bruno-garcia deleted the feat/http-request-breadcrumb branch July 10, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP Request Breadcrumbs
4 participants