Add HTTP request breadcrumb

CHANGELOG.md

@@ -2,8 +2,9 @@
 
 ## Unreleased
 
-### Fetures
+### Features
 
+- Add HTTP request breadcrumb ([#1113](https://github.com/getsentry/sentry-dotnet/pull/1113))
 - Add ClearAttachments to Scope ([#1104](https://github.com/getsentry/sentry-dotnet/pull/1104))
 
 ## 3.6.1

src/Sentry/SentryHttpMessageHandler.cs

@@ -1,4 +1,5 @@
-using System;
+using System;
+using System.Collections.Generic;
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
@@ -63,16 +64,27 @@ protected override async Task<HttpResponseMessage> SendAsync(
 
             // Start a span that tracks this request
             // (may be null if transaction is not set on the scope)
+            var requestMethod = request.Method.Method.ToUpperInvariant();
+            var url = request.RequestUri?.ToString() ?? string.Empty;
+
             var span = _hub.GetSpan()?.StartChild(
                 "http.client",
                 // e.g. "GET https://example.com"
-                $"{request.Method.Method.ToUpperInvariant()} {request.RequestUri}"
+                $"{requestMethod} {url}"
             );
 
             try
             {
                 var response = await base.SendAsync(request, cancellationToken).ConfigureAwait(false);
 
+                var breadcrumbData = new Dictionary<string, string>
+                {
+                    { "url", url },
+                    { "method", requestMethod },
+                    { "status_code", ((int)response.StatusCode).ToString() }
+                };
+                _hub.AddBreadcrumb(string.Empty, "http", "http", breadcrumbData);
+
                 // This will handle unsuccessful status codes as well
                 span?.Finish(
                     SpanStatusConverter.FromHttpStatusCode(response.StatusCode)

test/Sentry.Tests/SentryHttpMessageHandlerTests.cs

@@ -1,4 +1,5 @@
-using System;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Net.Http;
 using System.Threading.Tasks;
@@ -120,5 +121,48 @@ public async Task SendAsync_ExceptionThrown_ExceptionLinkedToSpan()
             // Assert
             hub.Received(1).BindException(exception, Arg.Any<ISpan>()); // second argument is an implicitly created span
         }
+
+        [Fact]
+        public async Task SendAsync_Executed_BreadcrumbCreated()
+        {
+            // Arrange
+            var scope = new Scope();
+            var hub = Substitute.For<IHub>();
+                hub.When(h => h.ConfigureScope(Arg.Any<Action<Scope>>()))
+                   .Do(c => c.Arg<Action<Scope>>()(scope));
+
+            var url = "https://example.com/";
+
+            var urlKey = "url";
+            var methodKey = "method";
+            var statusKey = "status_code";
+            var expectedBreadcrumbData = new Dictionary<string, string>
+                {
+                    { urlKey, url },
+                    { methodKey, "GET" },
+                    { statusKey, "200" }
+                };
+            var expectedType = "http";
+            var expectedCategory = "http";
+            using var sentryHandler = new SentryHttpMessageHandler(hub);
+            using var client = new HttpClient(sentryHandler);
+
+            // Act
+            await client.GetAsync(url);
+            var BreadcrumbGenerated = scope.Breadcrumbs.First();
+
+            // Assert
+            Assert.Equal(expectedType, BreadcrumbGenerated.Type);
+            Assert.Equal(expectedCategory, BreadcrumbGenerated.Category);
+
+            Assert.True(BreadcrumbGenerated.Data.ContainsKey(urlKey));
+            Assert.Equal(expectedBreadcrumbData[urlKey], BreadcrumbGenerated.Data[urlKey]);
+
+            Assert.True(BreadcrumbGenerated.Data.ContainsKey(methodKey));
+            Assert.Equal(expectedBreadcrumbData[methodKey], BreadcrumbGenerated.Data[methodKey]);
+
+            Assert.True(BreadcrumbGenerated.Data.ContainsKey(statusKey));
+            Assert.Equal(expectedBreadcrumbData[statusKey], BreadcrumbGenerated.Data[statusKey]);
+        }
     }
 }