Skip to content

Commit

Permalink
Revert "feat(issue-details): Add streamlined sidebar and activity (#7…
Browse files Browse the repository at this point in the history
…7958)"

This reverts commit 2446a87.

Co-authored-by: scttcper <1400464+scttcper@users.noreply.github.com>
  • Loading branch information
2 people authored and 0Calories committed Sep 25, 2024
1 parent 585aced commit db38dc0
Show file tree
Hide file tree
Showing 7 changed files with 35 additions and 936 deletions.
4 changes: 2 additions & 2 deletions static/app/components/layouts/thirds.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export const HeaderNavTabs = styled(NavTabs)`
/**
* Base container for 66/33 containers.
*/
export const Body = styled('div')<{noRowGap?: boolean; sidebarOpen?: boolean}>`
export const Body = styled('div')<{noRowGap?: boolean}>`
padding: ${space(2)};
margin: 0;
background-color: ${p => p.theme.background};
Expand All @@ -132,7 +132,7 @@ export const Body = styled('div')<{noRowGap?: boolean; sidebarOpen?: boolean}>`
}
@media (min-width: ${p => p.theme.breakpoints.large}) {
display: ${p => (p.sidebarOpen ? 'grid' : 'block')};
display: grid;
grid-template-columns: minmax(100px, auto) 325px;
align-content: start;
gap: ${p => (!p.noRowGap ? `${space(3)}` : `0 ${space(3)}`)};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,9 @@ import {getConfigForIssueType} from 'sentry/utils/issueTypeConfig';
import {VisuallyCompleteWithData} from 'sentry/utils/performanceForSentry';
import normalizeUrl from 'sentry/utils/url/normalizeUrl';
import usePrevious from 'sentry/utils/usePrevious';
import {useSyncedLocalStorageState} from 'sentry/utils/useSyncedLocalStorageState';
import GroupEventDetailsContent from 'sentry/views/issueDetails/groupEventDetails/groupEventDetailsContent';
import GroupEventHeader from 'sentry/views/issueDetails/groupEventHeader';
import GroupSidebar from 'sentry/views/issueDetails/groupSidebar';
import StreamlinedSidebar from 'sentry/views/issueDetails/streamline/sidebar';

import ReprocessingProgress from '../reprocessingProgress';
import {
Expand Down Expand Up @@ -74,11 +72,6 @@ function GroupEventDetails(props: GroupEventDetailsProps) {
const prevEvent = usePrevious(event);
const hasStreamlinedUI = useHasStreamlinedUI();

const [sidebarOpen, _] = useSyncedLocalStorageState(
'issue-details-sidebar-open',
false
);

// load the data
useSentryAppComponentsData({projectId});

Expand Down Expand Up @@ -179,7 +172,6 @@ function GroupEventDetails(props: GroupEventDetailsProps) {
<StyledLayoutBody
data-test-id="group-event-details"
hasStreamlinedUi={hasStreamlinedUI}
sidebarOpen={sidebarOpen}
>
{groupReprocessingStatus === ReprocessingStatus.REPROCESSING ? (
<ReprocessingProgress
Expand All @@ -205,23 +197,15 @@ function GroupEventDetails(props: GroupEventDetailsProps) {
)}
{renderContent()}
</MainLayoutComponent>
{hasStreamlinedUI ? (
sidebarOpen ? (
<StyledLayoutSide hasStreamlinedUi={hasStreamlinedUI}>
<StreamlinedSidebar group={group} event={event} project={project} />
</StyledLayoutSide>
) : null
) : (
<StyledLayoutSide hasStreamlinedUi={hasStreamlinedUI}>
<GroupSidebar
organization={organization}
project={project}
group={group}
event={eventWithMeta}
environments={environments}
/>
</StyledLayoutSide>
)}
<StyledLayoutSide hasStreamlinedUi={hasStreamlinedUI}>
<GroupSidebar
organization={organization}
project={project}
group={group}
event={eventWithMeta}
environments={environments}
/>
</StyledLayoutSide>
</Fragment>
)}
</StyledLayoutBody>
Expand All @@ -230,10 +214,7 @@ function GroupEventDetails(props: GroupEventDetailsProps) {
);
}

const StyledLayoutBody = styled(Layout.Body)<{
hasStreamlinedUi: boolean;
sidebarOpen: boolean;
}>`
const StyledLayoutBody = styled(Layout.Body)<{hasStreamlinedUi: boolean}>`
/* Makes the borders align correctly */
padding: 0 !important;
@media (min-width: ${p => p.theme.breakpoints.large}) {
Expand Down
50 changes: 0 additions & 50 deletions static/app/views/issueDetails/streamline/activitySection.tsx

This file was deleted.

67 changes: 0 additions & 67 deletions static/app/views/issueDetails/streamline/groupActivityIcons.tsx

This file was deleted.

Loading

0 comments on commit db38dc0

Please sign in to comment.