-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue-details): Add streamlined sidebar and activity #77958
Conversation
} from 'sentry/icons'; | ||
import {GroupActivityType} from 'sentry/types/group'; | ||
|
||
export const GroupActivityTypeIconMapping: Record<GroupActivityType, React.ReactNode> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my attempt at getting somewhat unique icons for each different activity type that somewhat matches the activity they are describing. will happily take suggestions for improvements here.
@@ -0,0 +1,701 @@ | |||
import {Fragment} from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a copy of the existing file but with each message reworded to fit our new title/message format
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
…y into roggenkemper/sidebartest
…y into roggenkemper/sidebartest
import {GroupActivityType} from 'sentry/types/group'; | ||
|
||
export const GroupActivityTypeIconMapping: Record<GroupActivityType, React.ReactNode> = { | ||
[GroupActivityType.NOTE]: <IconFile />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you want to do just IconFile and render it later since this version makes it hard to pass any props to and renders them when the app loads. Here's one with icons i tried recently
sentry/static/app/components/events/errorLevelText.tsx
Lines 23 to 30 in e7cc9c4
const errorLevelIconMap: Readonly<Record<Level, IconWithDefaultProps>> = { | |
error: {Component: IconClose, defaultProps: {isCircled: true}}, | |
fatal: {Component: IconFatal, defaultProps: {}}, | |
info: {Component: IconInfo, defaultProps: {}}, | |
warning: {Component: IconWarning, defaultProps: {}}, | |
sample: {Component: null, defaultProps: {}}, | |
unknown: {Component: null, defaultProps: {}}, | |
}; |
[GroupActivityType.NOTE]: <IconFile />, | |
[GroupActivityType.NOTE]: IconFile, |
GroupActivityType, | ||
IconWithDefaultProps | ||
> = { | ||
[GroupActivityType.NOTE]: {Component: IconFile, defaultProps: {}}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you don't need the defaultProps you don't need to add it lol
[GroupActivityType.AUTO_SET_ONGOING]: {Component: IconPlay, defaultProps: {}}, | ||
[GroupActivityType.SET_ESCALATING]: { | ||
Component: IconGraph, | ||
defaultProps: {type: 'area'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh you did
PR reverted: e696dc7 |
Reverting because this change broke thirds layout on other pages |
new version of #77958 , which was reverted because the condition for not using a grid layout was being read as false (undefined) on non-issues pages. this pr updates it to only change the layout of the issue details container so it won't affect any other page.
this pr adds in the dismissible sidebar and a first version of adding activity to the sidebar. the sidebar can now be dismissed, allowing for the rest of the issue details page to be displayed larger. the first version of activity in the sidebar will only show activities, the ability to comment is not added yet (will be done in a separate PR). Because of this, the tab will still be there until then. ![Screenshot 2024-09-23 at 10 03 30 AM](https://github.com/user-attachments/assets/1c092938-09ed-474c-a85f-e00fcf2f2108)
new version of #77958 , which was reverted because the condition for not using a grid layout was being read as false (undefined) on non-issues pages. this pr updates it to only change the layout of the issue details container so it won't affect any other page.
this pr adds in the dismissible sidebar and a first version of adding activity to the sidebar. the sidebar can now be dismissed, allowing for the rest of the issue details page to be displayed larger. the first version of activity in the sidebar will only show activities, the ability to comment is not added yet (will be done in a separate PR). Because of this, the tab will still be there until then.