feat(issue-views): Add character limits on tab titles #77883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #77883 +/- ##
=======================================
Coverage 78.12% 78.12%
=======================================
Files 6996 6996
Lines 310241 310243 +2
Branches 50763 50763
=======================================
+ Hits 242363 242366 +3
Misses 56145 56145
+ Partials 11733 11732 -1 |
malwilley
approved these changes
Sep 23, 2024
MichaelSun48
deleted the
msun/issueViews/enforceSoftAndHardLimitsOnTabTitle
branch
MichaelSun48
added
the
Trigger: Revert
|
PR reverted: 84813e6 |
getsentry-bot
added a commit
that referenced
this pull request
Sep 23, 2024
This reverts commit e8d991b. Co-authored-by: MichaelSun48 <55160142+MichaelSun48@users.noreply.github.com>
MichaelSun48
added a commit
that referenced
this pull request
Sep 23, 2024
This PR is nearly identical to [this previous PR](#77883) that I reverted because of an unexpected visual bug that occurred because of a conflict with another PR. (specifically [this one](#77890) that added animation wrappers over the tab title) The behavior is identical to the previous PR, see that one for a visual demo. This PR also fixes an unrelated bug with the duplicate functionality. Previously, clicking on the "Duplicate" action for a tab would flash the Add View page before going back to the issue stream. This happened because the add view page is automatically triggered when the search's viewId begins with a "_", indicating a tab that has not been persisted on our backend yet.
harshithadurai
pushed a commit
that referenced
this pull request
Sep 24, 2024
Adds "soft" and hard limits to the number of characters in the tab titles to prevent any weird behavior. The hard limit is 128 characters since this is the max character length enforced by the database schema. The soft character limit is approximately 50 characters, and a tooltip showing the full title will appear on hover if the tab title exceeds the maximum width. https://github.com/user-attachments/assets/72f47938-5ecf-4ed3-820b-9302a4260cec
harshithadurai
pushed a commit
that referenced
this pull request
Sep 24, 2024
This reverts commit e8d991b. Co-authored-by: MichaelSun48 <55160142+MichaelSun48@users.noreply.github.com>
harshithadurai
pushed a commit
that referenced
this pull request
Sep 24, 2024
This PR is nearly identical to [this previous PR](#77883) that I reverted because of an unexpected visual bug that occurred because of a conflict with another PR. (specifically [this one](#77890) that added animation wrappers over the tab title) The behavior is identical to the previous PR, see that one for a visual demo. This PR also fixes an unrelated bug with the duplicate functionality. Previously, clicking on the "Duplicate" action for a tab would flash the Add View page before going back to the issue stream. This happened because the add view page is automatically triggered when the search's viewId begins with a "_", indicating a tab that has not been persisted on our backend yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "soft" and hard limits to the number of characters in the tab titles to prevent any weird behavior. The hard limit is 128 characters since this is the max character length enforced by the database schema. The soft character limit is approximately 50 characters, and a tooltip showing the full title will appear on hover if the tab title exceeds the maximum width.
Screen.Recording.2024-09-20.at.4.42.14.PM.mov