feat(issue-views): Tab title char limits (dupe) #77966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
roggenkemper
approved these changes
Sep 23, 2024
harshithadurai
pushed a commit
that referenced
this pull request
Sep 24, 2024
This PR is nearly identical to [this previous PR](#77883) that I reverted because of an unexpected visual bug that occurred because of a conflict with another PR. (specifically [this one](#77890) that added animation wrappers over the tab title) The behavior is identical to the previous PR, see that one for a visual demo. This PR also fixes an unrelated bug with the duplicate functionality. Previously, clicking on the "Duplicate" action for a tab would flash the Add View page before going back to the issue stream. This happened because the add view page is automatically triggered when the search's viewId begins with a "_", indicating a tab that has not been persisted on our backend yet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is nearly identical to this previous PR that I reverted because of an unexpected visual bug that occurred because of a conflict with another PR. (specifically this one that added animation wrappers over the tab title)
The behavior is identical to the previous PR, see that one for a visual demo.
This PR also fixes an unrelated bug with the duplicate functionality. Previously, clicking on the "Duplicate" action for a tab would flash the Add View page before going back to the issue stream. This happened because the add view page is automatically triggered when the search's viewId begins with a "_", indicating a tab that has not been persisted on our backend yet.