feat(snuba/replay): bump snuba-sdk ver. and disable sampling in replay tag key queries #78534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
3 tasks
aliu39
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78534 +/- ##
===========================================
+ Coverage 57.39% 78.12% +20.73%
===========================================
Files 7070 7087 +17
Lines 311729 312575 +846
Branches 50937 51060 +123
===========================================
+ Hits 178904 244206 +65302
+ Misses 128086 62003 -66083
- Partials 4739 6366 +1627 |
ryan953
reviewed
Oct 3, 2024
| data.sort(key=lambda val: val["name"]) | ||
| assert data == [ | ||
| {"key": "drink", "name": "Drink", "totalValues": 1}, | ||
| {"key": "fruit", "name": "Fruit", "totalValues": 4}, |
There was a problem hiding this comment.
Is this number of total values, or number of unique values?
There was a problem hiding this comment.
total times a key appears, regardless of value! see test_simple
ryan953
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us query OrganizationTagsEndpoint with dataset=replays.
Ref #78531
-> depends on getsentry/snuba#6378.