Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(replay): query custom tags from replays dataset #78573

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Oct 3, 2024

Depends on #78534
Closes #78531 🎉

This query is used for the "Tags" section in replay search bar's suggestions/typeahead. With this, we'll only display tags placed on replays for that org (not on issues, traces, etc).

@aliu39 aliu39 requested review from a team as code owners October 3, 2024 20:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 3, 2024
@aliu39 aliu39 merged commit 5bc828b into master Oct 3, 2024
43 checks passed
@aliu39 aliu39 deleted the aliu/replay-tag-suggestions branch October 3, 2024 20:52
aliu39 added a commit that referenced this pull request Oct 3, 2024
@aliu39 aliu39 added the Trigger: Revert add to a merged PR to revert it (skips CI) label Oct 3, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: e44e3dd

getsentry-bot added a commit that referenced this pull request Oct 3, 2024
This reverts commit 5bc828b.

Co-authored-by: aliu39 <159852527+aliu39@users.noreply.github.com>
@aliu39 aliu39 restored the aliu/replay-tag-suggestions branch October 3, 2024 21:43
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #78573      +/-   ##
==========================================
- Coverage   78.13%   74.76%   -3.38%     
==========================================
  Files        7089     7091       +2     
  Lines      312501   312790     +289     
  Branches    51052    51140      +88     
==========================================
- Hits       244172   233843   -10329     
- Misses      61958    72271   +10313     
- Partials     6371     6676     +305     

@aliu39 aliu39 deleted the aliu/replay-tag-suggestions branch October 4, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tag key queries for replay dataset
4 participants