fix(resizer): remove delay to call resize by content to avoid flickering #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 212 212
Lines 13130 13133 +3
Branches 4305 4307 +2
=========================================
+ Hits 13130 13133 +3
Continue to review full report at Codecov.
|
AnnetteZhang
approved these changes
May 17, 2021
ghiscoding-SE
pushed a commit
that referenced
this pull request
May 17, 2021
- loading of Columns Grid Presets should only be done once (before resizing) and loading Filters Grid Presets could be done one or more times, so to fix this I have separated `loadPresetsWhenDatasetInitialized` into 2 new methods and made sure to call the columns grid preset only once. - this issue was identified while porting the previous PR #341 into Angular-Slickgrid
ghiscoding-SE
pushed a commit
that referenced
this pull request
May 21, 2021
- resizer service init must be done only after SlickGrid is initialized, else we end up binding our resize to a grid dom element that doesn't yet exist in the DOM - this regression bug wasn't caught earlier because there's no Cypress E2E to test that since it's too hard to test, basically it was caught manually since I found out the auto-resize stopped working (it failed silently) and I was wondering why that suddenly happened
ghiscoding
added a commit
that referenced
this pull request
May 21, 2021
fix(resizer): fix a regression bug caused by previous PR #341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.