Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resizer): fix a regression bug caused by previous PR #341 #347

Merged
merged 1 commit into from
May 21, 2021

Conversation

ghiscoding
Copy link
Owner

  • resizer service init must be done only after SlickGrid is initialized, else we end up binding our resize to a grid dom element that doesn't yet exist in the DOM
  • this regression bug wasn't caught earlier because there's no Cypress E2E to test that since it's too hard to test, basically it was caught manually since I found out the auto-resize stopped working (it failed silently) and I was wondering why that suddenly happened

- resizer service init must be done only after SlickGrid is initialized, else we end up binding our resize to a grid dom element that doesn't yet exist in the DOM
- this regression bug wasn't caught earlier because there's no Cypress E2E to test that since it's too hard to test, basically it was caught manually since I found out the auto-resize stopped working (it failed silently) and I was wondering why that suddenly happened
@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #347 (462e330) into master (e775cfa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #347   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          212       212           
  Lines        13135     13135           
  Branches      4307      4307           
=========================================
  Hits         13135     13135           
Impacted Files Coverage Δ
...bundle/src/components/slick-vanilla-grid-bundle.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e775cfa...462e330. Read the comment docs.

@ghiscoding ghiscoding merged commit 9ac7fbf into master May 21, 2021
@ghiscoding ghiscoding deleted the bugfix/auto-resize-regression branch May 21, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants