Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for pubnames/pubtypes/aranges #218

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Conversation

philipc
Copy link
Collaborator

@philipc philipc commented Jul 11, 2017

No description provided.

This avoids needing to use hacks for the docs, and ensures the docs stay
consistent.

It also makes error messages involving these types simpler, since they
now show the type the user thinks they are using, instead of the large
DebugLookup alias.
Before:
test bench_parsing_debug_aranges   ... bench:      33,146 ns/iter (+/- 2,739)
test bench_parsing_debug_pubnames  ... bench:      77,700 ns/iter (+/- 1,518)
test bench_parsing_debug_pubtypes  ... bench:      39,810 ns/iter (+/- 2,894)

After:
test bench_parsing_debug_aranges   ... bench:      29,536 ns/iter (+/- 2,591)
test bench_parsing_debug_pubnames  ... bench:      62,172 ns/iter (+/- 4,016)
test bench_parsing_debug_pubtypes  ... bench:      24,364 ns/iter (+/- 495)
They use the same parsing code, so they must be the same.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.463% when pulling 61b6ca2 on philipc:pubstuff into 4427fb1 on gimli-rs:master.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that the benches improved so much from that change; good stuff!

src/lookup.rs Outdated

fn parse_offset(input: &mut R, format: Format) -> Result<Self::Offset>;
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct PubStuffHeader {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh :-P

@fitzgen fitzgen merged commit 414f8a1 into gimli-rs:master Jul 11, 2017
@philipc philipc deleted the pubstuff branch July 12, 2017 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants