Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup for pubnames/pubtypes/aranges #218

Merged
merged 3 commits into from
Jul 11, 2017
Merged

Cleanup for pubnames/pubtypes/aranges #218

merged 3 commits into from
Jul 11, 2017

Commits on Jul 11, 2017

  1. Use new-types for DebugPubNames/DebugPubTypes/DebugAranges 

    This avoids needing to use hacks for the docs, and ensures the docs stay
consistent.

It also makes error messages involving these types simpler, since they
now show the type the user thinks they are using, instead of the large
DebugLookup alias.
    @philipc
    philipc committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    5e57f1a View commit details
    Browse the repository at this point in the history

  2. Simplify LookupEntryIter 

    Before:
test bench_parsing_debug_aranges   ... bench:      33,146 ns/iter (+/- 2,739)
test bench_parsing_debug_pubnames  ... bench:      77,700 ns/iter (+/- 1,518)
test bench_parsing_debug_pubtypes  ... bench:      39,810 ns/iter (+/- 2,894)

After:
test bench_parsing_debug_aranges   ... bench:      29,536 ns/iter (+/- 2,591)
test bench_parsing_debug_pubnames  ... bench:      62,172 ns/iter (+/- 4,016)
test bench_parsing_debug_pubtypes  ... bench:      24,364 ns/iter (+/- 495)
    @philipc
    philipc committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    ea66274 View commit details
    Browse the repository at this point in the history

  3. No need for separate PubNamesHeader and PubTypesHeader 

    They use the same parsing code, so they must be the same.
    @philipc
    philipc committed Jul 11, 2017
    Configuration menu
    Copy the full SHA
    61b6ca2 View commit details
    Browse the repository at this point in the history