Skip to content

Commit

Permalink
ci: change alert-threshold to 120% (#2880)
Browse files Browse the repository at this point in the history
Apologies for the whitespace changes; if you disable them, you'll see
it's a one-line change.

See [alert
threshold](https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#alert-threshold-optional)
on the documentation of the action.

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
  • Loading branch information
thehowl authored Oct 3, 2024
1 parent 41881ec commit e4d7528
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/benchmark-master-push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ jobs:
if: ${{ github.repository == 'gnolang/gno' }}
runs-on: [self-hosted, Linux, X64, benchmarks]
steps:
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 1

- uses: actions/setup-go@v5
with:
go-version: "1.22.x"
Expand All @@ -40,7 +40,7 @@ jobs:
with:
path: ./cache
key: ${{ runner.os }}-benchmark

- name: Store benchmark results into `gh-benchmarks` branch
uses: benchmark-action/github-action-benchmark@v1
# see https://github.com/benchmark-action/github-action-benchmark?tab=readme-ov-file#action-inputs
Expand All @@ -52,7 +52,7 @@ jobs:
external-data-json-path: ./cache/benchmark-data.json
max-items-in-chart: 100
# Show alert with commit comment on detecting possible performance regression
alert-threshold: '100%'
alert-threshold: '120%'
fail-on-alert: true
comment-on-alert: true
alert-comment-cc-users: '@ajnavarro,@thehowl,@zivkovicmilos'
Expand Down

0 comments on commit e4d7528

Please sign in to comment.