Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: change alert-threshold to 120% #2880

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Oct 2, 2024

Apologies for the whitespace changes; if you disable them, you'll see it's a one-line change.

See alert threshold on the documentation of the action.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@thehowl thehowl self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.95%. Comparing base (41881ec) to head (48fa3d4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2880      +/-   ##
==========================================
- Coverage   60.97%   60.95%   -0.02%     
==========================================
  Files         564      564              
  Lines       75273    75273              
==========================================
- Hits        45898    45884      -14     
- Misses      26008    26019      +11     
- Partials     3367     3370       +3     
Flag Coverage Δ
contribs/gnodev 61.46% <ø> (ø)
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 67.92% <ø> (ø)
gnovm 65.77% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (-0.36%) ⬇️
tm2 62.05% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehowl
Copy link
Member Author

thehowl commented Oct 2, 2024

@sw360cab disabled workflow for now; so at least we don't have failing CI

@thehowl thehowl closed this Oct 2, 2024
@thehowl thehowl reopened this Oct 3, 2024
@sw360cab sw360cab merged commit e4d7528 into master Oct 3, 2024
120 checks passed
@sw360cab sw360cab deleted the dev/morgan/benchmark-threshold branch October 3, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants