Skip to content

Commit

Permalink
Remove unnecessary and incorrect find('.menu').toggle() (#22987)
Browse files Browse the repository at this point in the history
Follows:
* #22950

The dropdown menu works well without these codes.

The reason is that the event bubbling still works for the dropdown menu,
the Fomantic UI dropdown menu module will hide the menu correctly if an
item is clicked.
  • Loading branch information
wxiaoguang committed Feb 20, 2023
1 parent f4ce8c7 commit 330b166
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions web_src/js/features/repo-issue.js
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,6 @@ export function initRepoIssueReferenceIssue() {
// Reference issue
$(document).on('click', '.reference-issue', function (event) {
const $this = $(this);
$this.closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line

const content = $(`#${$this.data('target')}`).text();
const poster = $this.data('poster-username');
const reference = $this.data('reference');
Expand Down
2 changes: 0 additions & 2 deletions web_src/js/features/repo-legacy.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ export function initRepoCommentForm() {
async function onEditContent(event) {
event.preventDefault();

$(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line
const $segment = $(this).closest('.header').next();
const $editContentZone = $segment.find('.edit-content-zone');
const $renderContent = $segment.find('.render-content');
Expand Down Expand Up @@ -584,7 +583,6 @@ function initRepoIssueCommentEdit() {

// Quote reply
$(document).on('click', '.quote-reply', function (event) {
$(this).closest('.dropdown').find('.menu').toggle('visible'); // eslint-disable-line
const target = $(this).data('target');
const quote = $(`#${target}`).text().replace(/\n/g, '\n> ');
const content = `> ${quote}\n\n`;
Expand Down

0 comments on commit 330b166

Please sign in to comment.