Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary and incorrect find('.menu').toggle() #22987

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Feb 19, 2023

Follows:

The dropdown menu works well without these codes.

The reason is that the event bubbling still works for the dropdown menu, the Fomantic UI dropdown menu module will hide the menu correctly if an item is clicked.

@lunny lunny added topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Feb 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #22987 (890377e) into main (65fc2d1) will increase coverage by 47.41%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##           main   #22987       +/-   ##
=========================================
+ Coverage      0   47.41%   +47.41%     
=========================================
  Files         0     1139     +1139     
  Lines         0   150708   +150708     
=========================================
+ Hits          0    71456    +71456     
- Misses        0    70791    +70791     
- Partials      0     8461     +8461     
Impacted Files Coverage Δ
modules/markup/camo.go 85.00% <0.00%> (ø)
modules/graceful/context.go 17.39% <0.00%> (ø)
routers/api/v1/repo/subscriber.go 0.00% <0.00%> (ø)
routers/web/repo/projects.go 15.89% <0.00%> (ø)
modules/regexplru/regexplru.go 65.21% <0.00%> (ø)
routers/api/v1/org/org.go 77.41% <0.00%> (ø)
modules/session/redis.go 1.72% <0.00%> (ø)
services/repository/files/update.go 36.28% <0.00%> (ø)
routers/web/user/package.go 0.00% <0.00%> (ø)
models/system/appstate.go 59.25% <0.00%> (ø)
... and 1129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 19, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 19, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 19, 2023
@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Feb 19, 2023
@GiteaBot GiteaBot added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Feb 20, 2023
@jolheiser
Copy link
Member

🎺 🤖

@jolheiser jolheiser merged commit 330b166 into go-gitea:main Feb 20, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 20, 2023
@wxiaoguang wxiaoguang deleted the remove-menu-hide branch February 21, 2023 01:11
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 21, 2023
* upstream/main: (23 commits)
  add margin top to the top of branches (go-gitea#23002)
  Add me to maintainers (go-gitea#23026)
  Render access log template as text instead of HTML (go-gitea#23013)
  Use `gt-relative` class instead of the ambiguous `gt-pr` class  (go-gitea#23008)
  Fix intermittent panic in notify issue change content (go-gitea#23019)
  Improve pull_request_template.md (go-gitea#22888)
  Hide 2FA status from other members in organization members list (go-gitea#22999)
  handle deprecated settings (go-gitea#22992)
  Add scopes to API to create token and display them (go-gitea#22989)
  Remove unnecessary and incorrect `find('.menu').toggle()` (go-gitea#22987)
  Improve issues.LoadProject (go-gitea#22982)
  Add 1.18.4 changelog (go-gitea#22991) (go-gitea#22995)
  Fix pull request branch selector visible without clicking Edit (go-gitea#23012)
  Bump golang.org/x/net from 0.4.0 to 0.7.0 (go-gitea#22980)
  Fix panic when call api (/repos/{owner}/{repo}/pulls/{index}/files) (go-gitea#22921)
  only trigger docs build and publish when docs changed (go-gitea#22968)
  Get rules by id when editing branch protection rule (go-gitea#22932)
  Fix hidden commit status on multiple checks (go-gitea#22889)
  Add me to maintainers (go-gitea#22998)
  Add all units to the units permission list in org team members sidebar (go-gitea#22971)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@delvh delvh added this to the 1.20.0 milestone May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants