Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PR link in issues dashboard #10158

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Fix PR link in issues dashboard #10158

merged 2 commits into from
Feb 6, 2020

Conversation

guillep2k
Copy link
Member

Fixes #10149

@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #10158 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10158      +/-   ##
==========================================
+ Coverage   43.41%   43.41%   +<.01%     
==========================================
  Files         576      576              
  Lines       79640    79640              
==========================================
+ Hits        34574    34575       +1     
+ Misses      40791    40789       -2     
- Partials     4275     4276       +1
Impacted Files Coverage Δ
modules/queue/workerpool.go 46.61% <0%> (-1.07%) ⬇️
routers/repo/view.go 40% <0%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c250ff...c09961d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2020
@techknowlogick techknowlogick added this to the 1.12.0 milestone Feb 6, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 6, 2020
@techknowlogick techknowlogick merged commit 727fc42 into go-gitea:master Feb 6, 2020
@techknowlogick
Copy link
Member

@guillep2k please send backport :)

guillep2k added a commit to guillep2k/gitea that referenced this pull request Feb 7, 2020
@guillep2k
Fix issue/pull link (go-gitea#10158)
816d21a
@guillep2k guillep2k mentioned this pull request Feb 7, 2020
Merged
@guillep2k guillep2k deleted the fix-10149 branch February 7, 2020 02:17
lunny pushed a commit that referenced this pull request Feb 7, 2020
@guillep2k
Fix issue/pull link (#10158) (#10173)
e48b460
@guillep2k
Copy link
Member Author

This can get the backport/done label.

@lafriks lafriks added the backport/done All backports for this PR have been created label Feb 15, 2020
@floemker floemker mentioned this pull request Nov 23, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagasme bagasme bagasme left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Generic pulls page don't link to specific pull
8 participants
@guillep2k @codecov-io @techknowlogick @6543 @bagasme @jolheiser @lafriks @GiteaBot