Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passcode invalid error to appear #14371

Conversation

ashmckenzie
Copy link
Contributor

This PR fixes a bug where an invalid passcode for 2FA is entered, but the The passcode is incorrect. Try again. error message is not displayed:

Settings - Gitea: Git with a cup of tea 2021-01-18 13-34-44

@codecov-io
Copy link

codecov-io commented Jan 18, 2021

Codecov Report

Merging #14371 (9fa50a1) into master (f95dce2) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14371      +/-   ##
==========================================
- Coverage   41.85%   41.84%   -0.01%     
==========================================
  Files         744      744              
  Lines       79738    79738              
==========================================
- Hits        33373    33370       -3     
- Misses      40857    40858       +1     
- Partials     5508     5510       +2     
Impacted Files Coverage Δ
routers/user/setting/security_twofa.go 15.67% <0.00%> (ø)
modules/git/repo_language_stats_nogogit.go 57.44% <0.00%> (-6.39%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-4.50%) ⬇️
modules/git/batch_reader_nogogit.go 44.77% <0.00%> (-1.50%) ⬇️
models/gpg_key.go 53.33% <0.00%> (-0.58%) ⬇️
models/error.go 38.98% <0.00%> (+0.48%) ⬆️
modules/git/repo_commit_nogogit.go 65.00% <0.00%> (+1.66%) ⬆️
modules/indexer/stats/db.go 68.00% <0.00%> (+8.00%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95dce2...9fa50a1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 18, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 18, 2021
@lafriks lafriks added this to the 1.14.0 milestone Jan 18, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 18, 2021
@techknowlogick techknowlogick merged commit 127907c into go-gitea:master Jan 18, 2021
@ashmckenzie ashmckenzie deleted the ashmckenzie/fix-passcode-incorect-flash branch January 18, 2021 09:22
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jan 19, 2021
* master: (27 commits)
  Use path not filepath in routers/editor (go-gitea#14390)
  Display error if twofaSecret cannot be retrieved (go-gitea#14372)
  Check if label template exist first (go-gitea#14384)
  Allow passcode invalid error to appear (go-gitea#14371)
  exclude authored PRs from Review Requested filter (go-gitea#14368)
  Upgrade blevesearch dependency to v2.0.1 (go-gitea#14346)
  Implement ghost comment mitigation (go-gitea#14349)
  Add edit, delete and reaction support to code review comments on issue page (go-gitea#14339)
  Add review requested filter on pull request overview (go-gitea#13701)
  escape branch names in compare url (go-gitea#14364)
  label and milestone webhooks on issue/pull creation (go-gitea#14363)
  Fix middlewares sequences (go-gitea#14354)
  Sort issue search results by revelance (go-gitea#14353)
  KanBan: be able to set default board (go-gitea#14147)
  ...
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants