Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Location, Website and Description to API #15675

Merged
merged 3 commits into from
May 1, 2021
Merged

Add Location, Website and Description to API #15675

merged 3 commits into from
May 1, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Apr 30, 2021

fixes #14248

@KN4CK3R KN4CK3R added the type/enhancement An improvement of existing functionality label Apr 30, 2021
@KN4CK3R KN4CK3R added this to the 1.15.0 milestone Apr 30, 2021
@6543 6543 added the modifies/api This PR adds API routes or modifies them label Apr 30, 2021
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 30, 2021
@zeripath
Copy link
Contributor

I think we need to consider this slightly more carefully. I don't think we need to always return this data.

@6543
Copy link
Member

6543 commented Apr 30, 2021

well it's public on your profile page & optional so I think there is no issue

zeripath
zeripath approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't appear that these can be easily set by the API though

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 30, 2021
@6543
Copy link
Member

6543 commented Apr 30, 2021

@KN4CK3R would you mind to extend user edit api or do you like to put this into a new pull?

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Apr 30, 2021

I will change the edit api too.

@codecov-commenter
Copy link

Codecov Report

Merging #15675 (baedb1b) into master (3d5bb3e) will decrease coverage by 0.02%.
The diff coverage is 33.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15675      +/-   ##
==========================================
- Coverage   43.92%   43.90%   -0.03%     
==========================================
  Files         678      678              
  Lines       81741    81809      +68     
==========================================
+ Hits        35905    35916      +11     
- Misses      39984    40045      +61     
+ Partials     5852     5848       -4
Impacted Files Coverage Δ
models/oauth2.go 29.16% <ø> (ø)
modules/doctor/dbconsistency.go 4.57% <0.00%> (-1.23%) ⬇️
modules/public/public.go 46.57% <ø> (-8.22%) ⬇️
modules/structs/user.go 100.00% <ø> (ø)
routers/org/org.go 10.52% <0.00%> (ø)
routers/repo/issue_label.go 38.80% <0.00%> (ø)
routers/repo/setting.go 13.36% <0.00%> (ø)
routers/repo/view.go 41.24% <0.00%> (-0.09%) ⬇️
routers/routes/install.go 0.00% <0.00%> (ø)
routers/user/auth.go 12.36% <0.00%> (-0.21%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5811e16...baedb1b. Read the comment docs.

@zeripath zeripath merged commit 67e1039 into go-gitea:master May 1, 2021
@KN4CK3R KN4CK3R mentioned this pull request May 1, 2021
Merged
@6543 6543 changed the title Add Location, Website and Biography to API Add Location, Website and Description to API May 2, 2021
6543 pushed a commit that referenced this pull request May 2, 2021
@KN4CK3R
Addition to (Add Location, Website and Description to API #15675) (#1…
8c8471e 
…5690)

* Use same name as other structs.

* Sync with normal forms.

* Edit description with API.

* Workaround for nil value.
@KN4CK3R KN4CK3R deleted the feature-api-user-addition branch May 7, 2021 06:29
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@6543 6543 6543 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

Location, Website and Biography not readable with API
6 participants
@KN4CK3R @zeripath @6543 @codecov-commenter @GiteaBot @lunny