Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition to #15675 #15690

Merged
merged 6 commits into from
May 2, 2021
Merged

Addition to #15675 #15690

merged 6 commits into from
May 2, 2021

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented May 1, 2021

Addition to #15675

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 1, 2021
@zeripath
Copy link
Contributor

zeripath commented May 1, 2021

@KN4CK3R CI fail is related I'm afraid

@codecov-commenter
Copy link

Codecov Report

Merging #15690 (c2f23a2) into master (ae6d786) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15690   +/-   ##
=======================================
  Coverage   43.90%   43.90%           
=======================================
  Files         678      678           
  Lines       81827    81868   +41     
=======================================
+ Hits        35926    35944   +18     
- Misses      40051    40076   +25     
+ Partials     5850     5848    -2     
Impacted Files Coverage Δ
modules/structs/user.go 100.00% <ø> (ø)
routers/api/v1/admin/user.go 36.99% <0.00%> (-0.44%) ⬇️
modules/queue/workerpool.go 51.64% <0.00%> (-8.36%) ⬇️
modules/git/last_commit_cache_nogogit.go 35.18% <0.00%> (-1.36%) ⬇️
modules/git/commit_info_nogogit.go 70.09% <0.00%> (+0.29%) ⬆️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
services/pull/check.go 28.76% <0.00%> (+2.73%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️
modules/git/repo_commit_nogogit.go 66.19% <0.00%> (+5.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6d786...c2f23a2. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2021
@6543 6543 added modifies/api This PR adds API routes or modifies them skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 2, 2021
@6543 6543 merged commit 8c8471e into go-gitea:master May 2, 2021
@KN4CK3R KN4CK3R deleted the feature-api-user-edit branch May 7, 2021 06:26
@go-gitea go-gitea locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants